Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override sample rate #14

Closed
wants to merge 1 commit into from
Closed

Don't override sample rate #14

wants to merge 1 commit into from

Conversation

Bombfuse
Copy link
Contributor

Upgrading to the latest changes caused it to be unable to play my .wavs, removing the sample rate override seems to fix the issue.
error : could not build output stream : The requested stream format is not supported by the device.

@madwareru
Copy link
Contributor

madwareru commented Oct 18, 2020

PR near just fix this already (#13)
To just remove this change is wrong because we could create device with sample rate 48000, which will result in incorrect playback (pitch will be uplifted as well as playing speed). In my latest change I switched to search if it could be possible to set such a sample rate and if so, we set it. If there is no such format available we keep things as is. It's still bad but could be better for platforms other than windows

@Bombfuse
Copy link
Contributor Author

I'm not super familiar with how sounds work in software, I'll close this out in favor of the other PR open

@Bombfuse Bombfuse closed this Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants