Wait for PCM to be ready before writing #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work, not an easy thing to fix for sure! A "wait" in the loop looks a bit suspicious, but your arguments are strong enough to merge it :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pop!_OS has fixed the missing default setting for Alsa, but it was set to pulseaudio instead of pipewire.
This PR fixes an issue where attempt to write frames to pulseaudio would crash/block the audio thread. Adding this wait fixes it, please don't ask me why, I've no idea what I'm doing here. Tested both pulse and pipewire with the change and both are working.