Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qts_split, qts_use & qTranslate-X 3.1 #107

Closed
johnclause opened this issue Feb 25, 2015 · 1 comment
Closed

qts_split, qts_use & qTranslate-X 3.1 #107

johnclause opened this issue Feb 25, 2015 · 1 comment

Comments

@johnclause
Copy link
Contributor

Hi Pedro, I have just discovered that -slug seem to override the behaviour of functions _split and _use, which I did not expect. Please, read release notes https://wordpress.org/support/topic/release-31-notes for version 3.1 of qTranslate-X. I believe it makes -X to be incompatible with -slug. You need to remove all customization of qtrans_ functions for -X integration. Besides, as far as I understood, what you optimized in your custom functions is already done in -X as well. If you can think of other improvements for _split, and _use, let me know I will implement them within -X, but -slug should not duplicate the same functions. In the past, when qTranslate was not available for modifications, it made good sense, but with -X now, all such customizations need to be removed. We can change the code of -X with any of your improvements. Please, let me know what else you improved, which I do not have yet in -X.
I am sorry about this, I had no idea that those were customized in -slug, otherwise I would coordinate this change with you.

@LC43
Copy link
Collaborator

LC43 commented Apr 12, 2015

nice to see some those changes! i've reverted ( its in the wp repo, for now)

@LC43 LC43 closed this as completed Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants