Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for pre-checks the same way as we do with post-checks #3

Closed
not-raspberry opened this issue May 19, 2015 · 0 comments
Closed

Wait for pre-checks the same way as we do with post-checks #3

not-raspberry opened this issue May 19, 2015 · 0 comments
Assignees

Comments

@not-raspberry
Copy link
Owner

Running a service with execute and at least one check may fail if the previous service didn't terminate on time:

  1. Process X₁ is ran with the executor.
  2. SIGTERM is sent to the process X₁ but the service takes some time to tear down
  3. Process X₂ is ran with the executor - pre-checks fail because they see the previous service.
  4. X₁ terminates after some time but it's too late - X₂'s executor failed.

DRY polling - currently there is a simple wait_until implementation in test.wait and a polling loop inside the execute function. There will be another polling for the pre-checks so the rule of three has to be applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant