Replace USB controllers with qemu-xhci for macOS Sonoma support
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We have skipped reviewing this pull request. We don't currently review these file types ['.in'] - Let us know if you'd like us to change this.
|
@manuth I'll add this to the code myself while keeping both the other usb devices too. Let me know if that wouldn't work and ill reopen this, else it is closed and thank you |
|
I'll give it a try once you pushed the changes |
|
actually no i'll just replace it all with your changes |
|
Awesome! Thank you very much 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this commit will fix #103 by replacing the
ich9-echi1controller with aqemu-xhcicontroller as recommended on Reddit: https://www.reddit.com/r/macOSVMs/s/kzSuQrgOgt.Setting the address of the controller to
<address type="pci" domain="0x0000" bus="0x01" slot="0x00" function="0x0"/>(virt-managers default), causes USB devices to not be picked up.For that reason, the address from this repository was used, which seems to work out just fine:
<address type='pci' domain='0x0000' bus='0x00' slot='0x1d' function='0x0'/>.Unlike recommended on Reddit, the ports does not seem to be necessary. macOS 14.4 works just fine with the changes made in this PR.
When I limited the ports as recommended on Reddit (by adding
ports='7'to thecontroller-tag), I also had to setUEFI -> ProtocolOverrides -> HashServicestotruein OpenCore'sconfig.plistfile. Otherwise, a notification "Volume Hash Mismatch" notification was shown each time I booted up the VM.