Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL support #7

Closed
sinahamedi67 opened this issue Oct 10, 2022 · 1 comment
Closed

RTL support #7

sinahamedi67 opened this issue Oct 10, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@sinahamedi67
Copy link

Hi,
In RTL languages, paddings are not correct, checkmark padding should be on the left, and icon padding should be on the right.

image

I just reversed the paddings in buildChild method of the SelectablePullDownMenuItem class. Now it's fine for RTL languages:

image

But there should be a better way to make it locale-aware. So it works in both directions.

Thanks in advance

@notDmDrl notDmDrl added the bug Something isn't working label Oct 11, 2022
@notDmDrl
Copy link
Owner

Hi @sinahamedi67

I've published an update with fix for this.

If there are still some problems with RTL please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants