Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open in Default App doesnt work when notes are in a volume that reports all files are executable (google drive) #1614

Open
10kc-emilyk opened this issue May 20, 2022 · 1 comment

Comments

@10kc-emilyk
Copy link

10kc-emilyk commented May 20, 2022

  • OS Version: darwin 12.3.1
  • Notable Version: v1.9.0-beta.9

Current behavior

When storing my notes in Google Drive using Google Drive File Stream, when i choose "open in default app", the file doesn't open.

Expected behavior

The markdown file should open in Typora (markdown editor i have set as my default markdown application) when I choose "open in default application". It worked in 1.8.

Notes

I looked at the underlying code by extracting the asar, and noticed that you're checking for an executable bit before opening the file, and refusing to open if it has executable access.

/Volumes/GoogleDrive/My Drive/notable/notes
» command ls -l
-rwx------@ 1 emily.klassen  staff  18152 19 May 11:19 Standups.md

In the google drive file stream volume, all of the files are marked with executable permissions, and chmod -x has no effect.

@forivall
Copy link

I would try to use libmagic on unix systems, either by shelling out to file, or using the mmmagic native bindings. I tested both and they work, though i didnt test mmmagic in electron, just regular ol node 16.4.2 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants