Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable URL scheme links #1694

Open
jhconning opened this issue Sep 28, 2023 · 1 comment
Open

enable URL scheme links #1694

jhconning opened this issue Sep 28, 2023 · 1 comment

Comments

@jhconning
Copy link

jhconning commented Sep 28, 2023

Feature description

Notable should allow URL scheme links to work for trusted apps such as vscode://, imdone://, zotero://
They currently appear to be blocked.

Feature motivation

Notable commands can be issued via URL scheme from outside of the app (e.g. notable://note/_scratch works from a browser or from imdone). This is useful and powerful. A link such as notable://note/scratch within a note in notable will also trigger a command. However, URL scheme links for outside apps such as vscode, zotero, and imdone do not appear to work. Nothing happens on click. This suggests they are being blocked by the app.

While there could be security concerns inherent to authorizing all URL schemes, the apps I have listed are all well-established and they would greatly enhance the value of the Notable app (e.g. zotero:// links would pull up citations in a zotero database, or vscode:// links could jump to code in an IDE).

I suggest either

(1) enable all URL scheme links (each user should be responsible for what they click on in their own notes ... if you're concerned make this a setting), or
(2) have a whitelist of authorized apps where URL scheme links are allowed.

@fabiospampinato
Copy link
Member

There should be a setting for this, and when the app is asked to trigger an unknown protocol it just asks the user if they want to allow it, and if so it adds it to the allowed ones automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants