New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PlantUML support #379
Comments
@kulkarniamit Just add your "👍" to the main post, "+1" comments just waste people's time. I've taken a closer look at this and it seems that PlantUML is a Java application, and JS plugins that enable support for it, like this work pretty weirdly, basically encoding diagrams in a url that plantuml.com will then render. On one hand this adds almost nothing to the codebase, on the other end who wants to wait for networks roundtrips, have this not work when offline, and having their diagrams transparently sent to a server somewhere? 🤔 If there was a WASM or pure-JS version of PlantUML this could be implemented a lot better I think 🤔 |
Reference Docker configuration, in case we decide to set-up our own PlantUML server: https://docs.gitlab.com/ee/administration/integration/plantuml.html#docker |
In case this feature goes live I personally would really appreciate if there is some kind of mechanism that ensures that every user knows about that external rendering is applied to one's notes. For example that one has to explicitly opt-in for PlantUML external rendering in the settings. |
@davidmichaelhuber IMHO the ideal scenario is:
As that's unlikely to happen I'd argue the next best thing is:
I'd rather not disable this by default for the following reasons:
Just my 2c, if any PlantUML users would like to share their thoughts I'd be interested in earing those. |
Factoring in the points you stated another opt-in strategy could be to capture I personally just like it much more having to opt-in instead of having to opt-out for features that affect an applications local boundaries. |
@davidmichaelhuber That sounds like a potentially good idea 🤔 Maybe that's the best option, however how many users that will have that icon/button/link shown to them would not click it? I can't imagine that that number being below 1% probably. |
I would argue that a yellow or maybe even a high contrast (to the background) icon might be pretty noticeable inside of the markdown editor pane where one would only expect plain text. Also another indicator for the user will be the fact that their The same opt-in mechanism then could also be used for external renderers that might be requested in the future. |
Done. I'll post a preview in the subreddit about this as soon as I have a few more features to showcase too. I haven't added a confirmation dialog as I don't think that would be very useful, I'm however hosting the renderer myself for added privacy: http://plantuml.notable.md I'll add an option for supplying a custom renderer url, which other than enhancing privacy would make this work faster if the renderer is hosted locally. |
Any hopes about this feature will be available anytime soon. No release after 20 Jan 2020, rendering isn't working for the insider version. |
The plantuml server is a big finicky at times, I haven't narrowed down why, you can try changing the endpoint from the setting to the official one, which I believe is either |
Feature description
Just as mermaid is supported, I would like to see plantuml diagrams(plantuml.com) supported as well
Feature motivation
Would make it possible to add uml digrams to noites
The text was updated successfully, but these errors were encountered: