Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing abstract methods for an abstract class for documentation #87

Closed
wants to merge 8 commits into from

Conversation

antonyip
Copy link

@antonyip antonyip commented Nov 2, 2019

This PR closes #30 .

I've looked through all the functions and didn't find much missing in the code base documentation..

Please let me know if I missed something..

@notadamking
Copy link
Collaborator

Hi @antonyip, I will need to look over your changes later, but they do not seem correct at first glance.

Also, #30 is about documenting the entire codebase, not sure how this is related.

@antonyip antonyip closed this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Request: Document the existing codebase using ReadTheDocs and Sphinx
2 participants