Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHD support #166

Closed
iax2RqPZbq opened this issue Jul 4, 2020 · 6 comments
Closed

Add CHD support #166

iax2RqPZbq opened this issue Jul 4, 2020 · 6 comments

Comments

@iax2RqPZbq
Copy link

CHD allows for optimal, lossless compression, and is supported in many other emulators (including MAME). It is superior to PBP.

I want to check thoughts on adding CHD support (there is a previous closed issue #107). It is supported in the libretro fork; we wouldn't need to use any code from it directly, but maybe some of it can easily be copied over. We can otherwise use libchdr directly.

@gameblabla
Copy link
Contributor

I have done a PR that does just that for PCSX Rearmed :
#188

Sadly notaz is currently busy so he can't test my patches yet but if you compile it and apply my patches, it will work.
(I tested it and it's pretty nice)

I may look into merging the async CD option later for platforms with slow storage access.

@gameblabla
Copy link
Contributor

It's merged so that can be closed. I've tested it and it works. For the async patch, i'll do that later.

@notaz
Copy link
Owner

notaz commented Aug 18, 2021

But it's not added to the build yet?

@gameblabla
Copy link
Contributor

gameblabla commented Aug 19, 2021

Oh right yeah, it needs to be manually enabled in config.mak for now...
I said that i would wait for #187 but if i introduce a PR to enable CHD support, it risks conflicting with it.
#187 is a big patch though... Should i do a PR for enabling CHD in configure and worry about #187 later ?

@Formedras
Copy link

Does the PR code support child CHDs? It would be nice to be able to store (for example) a SotN Randomizer disc image as just a child CHD and link it to the full disc, rather than having both full-size images on a drive.

@notaz
Copy link
Owner

notaz commented Sep 29, 2023

It just uses libchdr so supports whatever that supports. If there is still something missing please open another issue.

@notaz notaz closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants