Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Don't force style and tab icons when toogling dark mode #10049

Closed
ozone10 opened this issue Jun 21, 2021 · 3 comments
Closed
Assignees
Labels
dark mode Dark mode related issues, fixes

Comments

@ozone10
Copy link
Contributor

ozone10 commented Jun 21, 2021

Description of the Issue

Don't force style and tab icons when toggling dark mode.
Make it optional, or allow to choose default styles and icons.

I am using my own dark and light theme, and it can be annoying when toggling between modes.
For icon currently many plugins don't support new darkmode icons, so they appear blank, when using fluent icons.
So I currently prefer standard icon set.

Steps to Reproduce the Issue

  1. Open preferences
  2. Enable or disable dark mode

Expected Behavior

Style and icons remain same.

Actual Behavior

Icon is changed to fluent and style to Default or DarkModeDefault.

Debug Information

@donho
Copy link
Member

donho commented Jul 20, 2021

@ozone10
In order to provide a better UX for ppl who switch to dark mode for the first time, it's inevitable to show users the "suitable" configuration. For me, if users have tried dark mode, they should decide which side they wanna stay. Maybe it could not the case for the developers of this project (ie. you and others who are working in dark mode), but for the most of users, you are in dark mode, or you are not. Am I missing some points?

@ozone10
Copy link
Contributor Author

ozone10 commented Jul 20, 2021

@donho
What about adding checkbox Use default style theme, which will be enabled by default.
Same with toolbar icons.

@donho
Copy link
Member

donho commented Jul 22, 2021

@ozone10
If we add more options for 1 option, then there's a problem.
Too many options, no option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dark mode Dark mode related issues, fixes
Projects
None yet
Development

No branches or pull requests

3 participants