Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plugin-shared code into a separate header #103

Closed
ariccio opened this issue May 20, 2015 · 4 comments
Closed

Refactor plugin-shared code into a separate header #103

ariccio opened this issue May 20, 2015 · 4 comments
Assignees
Labels
build / code known issue The issue was known, but won't be fixed or cannot be fixed plugin
Milestone

Comments

@ariccio
Copy link
Contributor

ariccio commented May 20, 2015

Git has a fantastic feature called a subtree that uses nested repositories to manage project dependencies.

Before anything, There's lots of good information about it:

Refactoring some of the headers into a separate repo would make it far easier for plugin developers to build & maintain up to date plugins, as they could update their copy of the headers with a simple git shell command.

I'm not a plugin developer, but as best I can tell, the very minimal headers that a plugin dev needs to include are roughly:

  • Notepad_plus_msgs.h
  • PluginInterface.h
  • Scintilla.h
  • menuCmdID.h
  • Window.h
  • Docking.h (maybe)
  • DockingDlgInterface.h (maybe)

I came up with this while studying/fixing multiple buffer overruns in HexEdit, which seems to have last updated its copy of the Notepad++ headers in _~2009_.

@ariccio ariccio mentioned this issue May 28, 2015
@milipili milipili modified the milestone: 6.x Jun 29, 2015
@milipili milipili added build / code plugin known issue The issue was known, but won't be fixed or cannot be fixed labels Jun 29, 2016
@milipili
Copy link
Contributor

milipili commented Jun 29, 2016

A real N++ SDK would be indeed a good thing to have

@milipili milipili changed the title Idea: refactor plugin-shared code into a separate Refactor plugin-shared code into a separate Jun 29, 2016
@milipili milipili changed the title Refactor plugin-shared code into a separate Refactor plugin-shared code into a separate header Jun 29, 2016
@milipili milipili self-assigned this Jun 29, 2016
@milipili
Copy link
Contributor

milipili commented Jun 29, 2016

@donho : could you give me the list of the n++ headers currently strictly required by any plugin ?

@donho
Copy link
Member

donho commented Jun 30, 2016

@milipili
https://github.com/npp-plugins/plugintemplate/blob/master/src/Notepad_plus_msgs.h

@donho donho closed this as completed Jun 30, 2016
@donho donho reopened this Jun 30, 2016
@donho
Copy link
Member

donho commented Jun 30, 2016

I think we can close this issue since there's only one file is mandatory.
Of course @milipili please reopen it if you judge it's necessary to reopen it.

@donho donho closed this as completed Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build / code known issue The issue was known, but won't be fixed or cannot be fixed plugin
Projects
None yet
Development

No branches or pull requests

3 participants