Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window -> Sort By: Update Document List #11272

Closed
Yaron10 opened this issue Feb 23, 2022 · 4 comments
Closed

Window -> Sort By: Update Document List #11272

Yaron10 opened this issue Feb 23, 2022 · 4 comments

Comments

@Yaron10
Copy link

Yaron10 commented Feb 23, 2022

STR:
Open some files.
Open the Document List panel.
Change the documents position via Window -> Sort By.

Result:
The order in Document List is not updated.
Sorting via the Window dialog, the Document List is updated..


Using the latest 2d1ba01 in Master.

@Yaron10 Yaron10 changed the title Window -> Sort BY: Update Document List Window -> Sort By: Update Document List Feb 23, 2022
@Ashfaaq18
Copy link
Contributor

In my case, sorting via the "Window->Sort By" option and the "Window dialog" does not update the Document List in NPP version 8.3.3

Debug Info:
Notepad++ v8.3.3 (64-bit)
Build time : Mar 13 2022 - 17:20:02
Path : D:..\npp.8.3.3.portable.x64\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 10 Pro (64-bit)
OS Version : 2009
OS Build : 19042.1586
Current ANSI codepage : 1252
Plugins : mimeTools.dll NppConverter.dll NppExport.dll

@Yaron10
Copy link
Author

Yaron10 commented Mar 19, 2022

@Ashfaaq18,

I've retested it.
Sorting via the Windows dialog, the Document List is not always updated.
It requires some more investigation.

Thank you.

@Yaron10
Copy link
Author

Yaron10 commented Mar 19, 2022

@Ashfaaq18,

Sorting via the Window dialog, the Document List is updated.

I was wrong. It's only updated in some cases.
As your PR fixes both menu and dialog, let's leave it.

Thanks again.

@Yaron10
Copy link
Author

Yaron10 commented Mar 20, 2022

@Ashfaaq18,

I felt some need to return to it. :)
Here is a case the Document List is correctly updated on sorting via the Dialog.
(It probably wasn't the constellation I had when I first posted the issue).

Open two files: B and A (B is first, A is second).
Select B.
Open the Document List.
Open the Windows Dialog.
Press on the Name header.
Sort.
Press on the Name header.
Sort.

At this stage, the Document List is in sync with the tabs' order.
It's related to my last comment in #11411 (comment).

Obviously, you were right and the Document List is not correctly updated on sorting via the Dialog.

@donho donho closed this as completed in 32580e6 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants