Dead code in StyleContext.cxx raising MSVC compiler warning

[rdipardo]

Description of the Issue

In older versions of Scintilla, StyleContext::GetCurrent made an internal call to a static ::getRange function:

notepad-plus-plus/scintilla/lexlib/StyleContext.cxx

Lines 67 to 69 in a29cfa8

	void StyleContext::GetCurrent(char *s, Sci_PositionU len) {
	getRange(styler.GetStartSegment(), currentPos - 1, styler, s, len);
	}

Scintila 5.1.1 removed it in favour of the LexAccessor::GetRange method.

It seems Notepad++ patched it back in during the recent Scintilla upgrade, even though ::getRange is no longer used internally and is no longer reachable by any code outside lexilla/lexlib/StyleContext.cxx because of its static linkage.

Unless I'm missing something, neither Scintilla nor Notepad++ needs ::getRange at all¹. Removing it will eliminate a distracting compiler warning.

Steps to Reproduce the Issue

cd PowerEditor\visual.net
msbuild /v:m /t:Lexilla /p:PlatformToolset=v141;Platform=x64;WindowsTargetPlatformVersion=%WindowsSDKVersion:~0,-1%

Expected Behavior

No compiler warnings.

Actual Behavior

 lexilla\lexlib\stylecontext.cxx(57, 13): warning C4505: 'getRange': unreferenced local function has been removed

Debug Information

Footnotes

1. A few older lexers implement their own "getRange" functions, all of them hidden by static linkage, e.g., LexCOBOL, LexOpal, LexTACL, LexTAL ↩

[ozone10]

Seems to be fixed with 100d45f

[rdipardo]

Seems to be fixed with 100d45f

Confirmed: 100d45f#diff-da44f0e1e38ab1bc371aae9ebe4b604b19bfaed344ad858ecace106192b67d7cL57

Good 👀!