Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem to append extension when saving with filename in Korean #11582

Open
daejungkim opened this issue Apr 26, 2022 · 6 comments
Open

Problem to append extension when saving with filename in Korean #11582

daejungkim opened this issue Apr 26, 2022 · 6 comments

Comments

@daejungkim
Copy link

daejungkim commented Apr 26, 2022

Description of the Issue

If the filename is Korean (maybe multi-byte character set) when saving file,
the added file extension is incorrect.
The last character of filename is added to the following of the 'txt' extension.

Steps to Reproduce the Issue

  1. Write something starting with Ctrl + N
  2. Save file with Ctrl + S
  3. Input filename with '한글' in the blue highlighted namefield while checked on "Append extension".
  4. Type '한글' by keyboard!
  5. The box cursor will be blinking in the last character like '글'.

Doing copy and paste '한글', it does not repoduce.
If you move the box cursor to the left or to the right, it does not reproduce.

  1. Press 'Enter' key!

By clicking 'Save' button, it does not reproduce.

  1. Then filename is '한글.txt글'

Expected Behavior

In a saving dialog, the input filename is written by '한글' then the output filename is to be '한글.txt'.

Actual Behavior

Debug Information

Notepad++ v8.3.3 (64-bit)
Build time : Mar 13 2022 - 17:20:02
Path : C:\Program Files\Notepad++\notepad++.exe
Command Line :
Admin mode : ON
Local Conf mode : OFF
Cloud Config : OFF
OS Name : Windows 10 Pro (64-bit)
OS Version : 1909
OS Build : 18363.1500
Current ANSI codepage : 949
Plugins : DoxyIt.dll MarkdownViewerPlusPlus.dll mimeTools.dll NppConverter.dll NppExport.dll NppMarkdownPanel.dll Python Indent.dll

@80ROkWOC4j
Copy link
Contributor

80ROkWOC4j commented May 8, 2022

8 버전 들어오면서 생긴 확장자 추가 기능에 버그를 고치면서 한글 IME와 문제가 생긴 것 같아요. 한자 입력 등 불필요한 상황에서도 엔터 이벤트가 항상 확장자를 뒤에 추가하고 있어요.
I think there is a problem with the Korean IME while fixing a bug in the "Append extension". Even in unnecessary situations such as inputting Chinese characters, the enter event always adds the extension at the end.

bug

Debug Information

Notepad++ v8.3.2 (64-bit)
Build time : Feb 27 2022 - 03:35:46
Path : C:\Program Files\Notepad++\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : OFF
Cloud Config : OFF
OS Name : Windows 11 (64-bit)
OS Version : 2009
OS Build : 22000.613
Current ANSI codepage : 949
Plugins : mimeTools.dll NppConverter.dll NppExport.dll

Notepad++ v8.4 (64-bit)
Build time : Apr 20 2022 - 03:31:06
Path : C:\Program Files\Notepad++\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : OFF
Cloud Config : OFF
OS Name : Windows 11 (64-bit)
OS Version : 2009
OS Build : 22000.613
Current ANSI codepage : 65001
Plugins : mimeTools.dll NppConverter.dll NppExport.dll

@80ROkWOC4j
Copy link
Contributor

80ROkWOC4j commented May 9, 2022

// Modifies the file name if necesary after user confirmed input.
// Called after the user input but before OnFileOk() and before any name validation. 
void onPreFileOk()

onPreFileOk is called before Korean IME ends its input. KbdProcHook might need to be changed. b5a5baf#diff-eeb5624a35a43795da4eb970149a9ce7d22858b678a242affd2357520ea3e9f2R607

@mere-human
Copy link
Contributor

onPreFileOk is called before Korean IME ends its input. KbdProcHook might need to be changed.

@80ROkWOC4j That's right. Any idea what's the condition should look like?

@80ROkWOC4j
Copy link
Contributor

80ROkWOC4j commented Jun 8, 2022

Windows IME's letter composition ends after enter hook.
To fix this bug without major code change, it seems that it need to hook the events of the Korean(maybe CJK) IME. Or roll back hook to button event. Imma try to hook IME.

@80ROkWOC4j
Copy link
Contributor

This issue does not occur in Japanese IME #11912 (comment)

@donho
Copy link
Member

donho commented Apr 15, 2024

906f6e4

@donho donho reopened this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants