Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.4.3 Regression: Find in files search results loses functionality after first search #11910

Closed
Wedge009 opened this issue Jul 13, 2022 · 8 comments

Comments

@Wedge009
Copy link

Wedge009 commented Jul 13, 2022

Greetings, I tried searching for an existing issue but they appear irrelevant as 8.4.3 was only just released. I confirmed the issue was not present in 8.4.2.

Description of the Issue

When using Find in files I can double-click lines in the search results to open the file where the search key was found. However, subsequent searches after the first one loses this functionality, among other things like collapsible results, and everything is rendered in plain-text.

This seems to be specific to the 'Find in files' feature, regular find is not affected. I'm not sure if it's related to the change mentioned in https://community.notepad-plus-plus.org/post/78110.

Steps to Reproduce the Issue

  1. Find in files (Ctrl+Shift+F)
  2. Run a search, preferably one that produces a result. This first search functions normally.
  3. Run subsequent searches and observe the results printed in plain-text.

Expected Behaviour

Same behaviour as for the first search and as exhibited in 8.4.2 and earlier.

Actual Behaviour

As above: search results are rendered in plain-text and usual functionality is lost.

Debug Information

Notepad++ v8.4.3 (64-bit)
Build time : Jul 7 2022 - 10:55:58
Path : C:\Program Files\Notepad++\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : OFF
Cloud Config : OFF
OS Name : Windows 7 Professional (64-bit)
OS Build : 7601.24544
Current ANSI codepage : 1252
Plugins : none

@CennoxX
Copy link
Contributor

CennoxX commented Jul 13, 2022

I think you mean 8.4.3 and 8.4.2?

@Wedge009 Wedge009 changed the title 6.4.3 Regression: Find in files search results loses functionality after first search 8.4.3 Regression: Find in files search results loses functionality after first search Jul 13, 2022
@Wedge009
Copy link
Author

Wedge009 commented Jul 13, 2022

Thank you, yes.

Just finished a long work day...

Edit: Speaking of which, I thought I had replicated on more than one machine but apparently not. I've updated the original report accordingly. Maybe it's an issue that's specific to Windows 7. Is Windows 7 still supported?

@Wedge009
Copy link
Author

Okay, this is getting weird. I replicated it on Windows 10 as well. Maybe I had done something else to get it working properly but a fresh Notepad++ session should exhibit the regression.

@rdipardo
Copy link
Contributor

Sounds a lot like #11883

This development build may work better: https://ci.appveyor.com/project/donho/notepad-plus-plus/builds/44124788/job/99g24uejgy2yp7hj/artifacts

@Wedge009
Copy link
Author

Yes, that looks like it. If it'll be resolved in 8.4.4 I can wait for its release, and happy for this to be closed in that case.

@ArkadiuszMichalski
Copy link
Contributor

@Wedge009 You can try portable and .exe from above link to confirm that it was fixed (instruction).

@donho
Copy link
Member

donho commented Jul 15, 2022

e6fe568

@donho donho closed this as completed Jul 15, 2022
@Wedge009
Copy link
Author

Working again in 8.4.4 release, thank you. (Long time 'happy user' here.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants