Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added scintilla 5.2.4 and lexilla 5.1.8 #12022

Closed
wants to merge 1 commit into from

Conversation

chcg
Copy link
Contributor

@chcg chcg commented Aug 18, 2022

Release 5.2.4
Released 10 July 2022.
Fix hiding selection when selection layer is SC_LAYER_UNDER_TEXT. Bug #2334.
Fix bad background colour for additional, secondary, and inactive selections when printing. Bug #2335.
Fix failures on GTK with non-UTF-8 text when multi-threading due to character set conversion code that was not thread-safe.
Fix crash when printing on Win32 in bidirectional mode with a non-empty selection.

Release 5.1.8

Released 10 July 2022.
F#: Recognize nested comments in F#. [Issue #93](https://github.com/ScintillaOrg/lexilla/issues/93).
MS SQL: Recognize nested comments in Transact-SQL. [Issue #87](https://github.com/ScintillaOrg/lexilla/issues/87).
MS SQL: Preference data types more consistently to not depend on how lexing is broken up into segments. This is needed because there are keywords that are both data type names and function names such as 'CHAR'. [Issue #90](https://github.com/ScintillaOrg/lexilla/issues/90).
PowerShell: Fix single quoted strings to not treat backtick as escape. [Pull request #92](https://github.com/ScintillaOrg/lexilla/pull/92).
Visual Prolog: Treat \r\n line ends the same as \n. This makes testing easier. Add test case. [Issue #83](https://github.com/ScintillaOrg/lexilla/issues/83).
Visual Prolog: Allow disabling verbatim strings. [Pull request #89](https://github.com/ScintillaOrg/lexilla/pull/89).
Visual Prolog: Support backquoted strings. [Pull request #89](https://github.com/ScintillaOrg/lexilla/pull/89).

@chcg chcg added the scintilla dependent Can't be considered for N++ implementation unless/until Scintilla changes label Aug 18, 2022
@rdipardo
Copy link
Contributor

Fix bad background colour for additional, secondary, and inactive selections when printing. Bug #2335.

Just a heads up — this will not fix that issue in N++'s case. It required some post-release work that's only in Scintilla's trunk at the moment: #11826 (comment)

@vinsworldcom
Copy link

Can confirm the PowerShell parser fix in lexilla 5.1.8 mentioned in this Notepad++ commit works!

@donho donho self-assigned this Aug 20, 2022
@ArkadiuszMichalski
Copy link
Contributor

ArkadiuszMichalski commented Aug 24, 2022

Lexilla 5.1.9 was released, Scintilla 5.3.0 probably will appear August 27 2022.

@donho
Copy link
Member

donho commented Aug 27, 2022

Lexilla 5.1.9 was released, Scintilla 5.3.0 probably will appear August 27 2022.

@ArkadiuszMichalski
Thank you for the info. Just checked on Scintilla official site, 5.3.0 is released.
For the sake of stability, let's keep scintilla 5.2.4 and lexilla 5.1.8 for Notepad++ v8.4.5 release.

@donho
Copy link
Member

donho commented Aug 27, 2022

Just a heads up — this will not fix that issue in N++'s case. It required some post-release work that's only in Scintilla's trunk at the moment: #11826 (comment)

@rdipardo
Thank you for the heads up. I saw Bug #2335 has been fixed in Scintilla 5.3.0.
So it will be fixed in the future versions (or I can do a hot fix by using the patch in Notepad++ next release).

@donho
Copy link
Member

donho commented Aug 27, 2022

@chcg
Just play around, looks good!
Thank you for the PR!

@donho donho closed this in 6a33bf6 Aug 27, 2022
@chcg chcg deleted the scintilla524 branch August 27, 2022 06:34
@chcg
Copy link
Contributor Author

chcg commented Aug 27, 2022

@donho @rdipardo See #12045 for 5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scintilla dependent Can't be considered for N++ implementation unless/until Scintilla changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants