Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPP RTL: Display Find in Files Progress window in RTL layout #13458

Closed
Yaron10 opened this issue Apr 1, 2023 · 3 comments
Closed

NPP RTL: Display Find in Files Progress window in RTL layout #13458

Yaron10 opened this issue Apr 1, 2023 · 3 comments

Comments

@Yaron10
Copy link

Yaron10 commented Apr 1, 2023

STR:
Set NPP interface to RTL.
Run Find in Files.

Result:
The Progress window is displayed in LTR layout.

WS_EX_APPWINDOW | WS_EX_TOOLWINDOW | WS_EX_OVERLAPPEDWINDOW,

Should be replaced with

WS_EX_APPWINDOW | WS_EX_TOOLWINDOW | WS_EX_OVERLAPPEDWINDOW | (pNativeSpeaker->isRTL() ? WS_EX_LAYOUTRTL : 0),

Notepad++ 8.5.1.

@alankilborn
Copy link
Contributor

@Yaron10

Is this how it should look?:

image

Probably not...

@Yaron10
Copy link
Author

Yaron10 commented Apr 7, 2023

@alankilborn,

That's the correct layout.
With the strings localized to RTL, it looks good. :)

Thank you. 👍

@alankilborn
Copy link
Contributor

With the strings localized to RTL

Yes, of course; I was just asking if the general picture was correct. And you've said it is, so thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants