Function List: Not all functions listed for a php file

[golgoth1009]

Description of the Issue

Using a php class file containing a lot of functions (around 188 functions),
some functions are present, some are missing in the list
I provide a PHP file as exemple (renamed to txt for the upload)

Steps to Reproduce the Issue

1. Load the file
2. Show the Function List
3. Look for isAbsPath(). This function will be missing in the list.
4. Then also functions following this one are missing

Expected Behavior

Have all the functions in the list

Actual Behavior

All functions after validPathStr() are missing

Debug Information

Notepad++ v8.5.2 (64-bit)
Build time : Apr 4 2023 - 19:55:32
Path : C:\Program Files\Notepad++\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : OFF
Cloud Config : OFF
OS Name : Windows 10 Pro N (64-bit)
OS Version : 21H2
OS Build : 19044.2846
Current ANSI codepage : 1252
Plugins :
AnalysePlugin (1.13.49)
CodeAlignmentNpp (14.1.107)
ComparePlugin (2.0.2)
HTMLTag (1.3.5)
mimeTools (2.9)
Npp-Highlighter (1.0.0.1)
NppConverter (4.5)
NppExport (0.4)
NPPJSONViewer (2.0.4)
NppTaskList (2.5)
NppXmlTreeviewPlugin (2)
XMLTools (3.1.1.13)

class.t3lib_div.txt

[vlakoff]

I tried this, and could not reproduce the issue. All functions are listed. (Notepad++ 8.6.2 32-bit)

Might be related: #14208. Ping @elmonty.
It would be interesting if you guys could try each other's testcase and see if you also encounter their bug.

[elmonty]

I can reproduce this behavior with the given file. If I remove all curly braces from the body of the function validPathStr(), then all the functions appear in the function list. Even though the original version of the function is perfectly good and valid PHP, the following version of the function causes all functions to appear in the function list:

public static function validPathStr($theFile) {
	if (strpos($theFile, '//') === FALSE && strpos($theFile, '\\') === FALSE && !preg_match('#(?:^\.\.|/\.\./|[[:cntrl:]])#u', $theFile))
		return TRUE;
	
	return FALSE;
}

At first, I suspected that the regular expression might be causing the issue, but removing just that condition alone did not solve the problem. The version of the function below still shows the issue where the remaining functions do not appear in the function list:

public static function validPathStr($theFile) {
	if (strpos($theFile, '//') === FALSE && strpos($theFile, '\\') === FALSE) {
		return TRUE;
	}

	return FALSE;
}

If I take the original version of the function and change the double slash in the string literal to a simple alphabetic character, all functions then appear in the function list:

public static function validPathStr($theFile) {
	if (strpos($theFile, 'x') === FALSE && strpos($theFile, '\\') === FALSE && !preg_match('#(?:^\.\.|/\.\./|[[:cntrl:]])#u', $theFile)) {
		return TRUE;
	}

	return FALSE;
}

So, either removing the curly braces or replacing the double slash causes the issue to disappear.

The following version of the code can be used as workaround until this bug is squashed. If you prefer, you can do the same for the double backslash to be consistent.

public static function validPathStr($theFile) {
	$DOUBLE_SLASH = '//';

	if (strpos($theFile, $DOUBLE_SLASH) === FALSE && strpos($theFile, '\\') === FALSE && !preg_match('#(?:^\.\.|/\.\./|[[:cntrl:]])#u', $theFile)) {
		return TRUE;
	}

	return FALSE;
}