Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable undocollection while loading a file #14455

Conversation

csware
Copy link
Contributor

@csware csware commented Dec 7, 2023

This reduces the amount of memory required to load a file by around half.

This reduces the amount of memory required to load a file by around half.

Signed-off-by: Sven Strickroth <email@cs-ware.de>
@xomx
Copy link
Contributor

xomx commented Dec 7, 2023

@csware
Great!
(Note: You should always find an existing or create a new issue for the PR as requested in the contribution rules.)

@donho @ArkadiuszMichalski
This PR fixes unwanted memory spikes at loading - here I used a ~5GB txt-file (5x reloaded):

npp86-memory-spikes

npp#PR14455-no-memory-spikes

This is the same pattern reported earlier:
#11047 (comment)
#11103 (comment)

This PR could help with bigger files loading (especially relevant for the more memory restrained x86 32-bit N++...).

@donho donho self-assigned this Dec 7, 2023
@donho donho added the accepted label Dec 7, 2023
@donho donho closed this in ef8ad11 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants