Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Adjustable empty space after margin #2323

Closed
Gitoffthelawn opened this issue Sep 23, 2016 · 15 comments
Closed

Feature Request: Adjustable empty space after margin #2323

Gitoffthelawn opened this issue Sep 23, 2016 · 15 comments
Assignees
Labels

Comments

@Gitoffthelawn
Copy link
Contributor

The border width setting comes close do doing what I want: to be able to adjust the empty space between the left border and the leftmost pixels of the text.

Instead of adding more empty space, however, that setting makes the border wider.

Can you add a setting (hidden or otherwise) to adjust the empty space between the left border and the leftmost pixels of the text?

(For RTL languages, replace "left" and "leftmost" with "right" and "rightmost", respectively.)

@NoneGiven
Copy link

This, please. Also between the top of the window and the topmost pixel of text. And between the cursor and the character to its left...

I hate to say it, but Windows Notepad's padding looks much nicer than NPP's:

Notepad++:

padding1

Notepad:

padding2

@sasumner
Copy link
Contributor

sasumner commented Sep 30, 2020

Closing as IMO this is not worth doing.
Regardless, this depends upon Scintilla and I haven't seen a function call that allows configuration.

@sasumner sasumner added the scintilla dependent Can't be considered for N++ implementation unless/until Scintilla changes label Oct 15, 2020
@morozover
Copy link

«empty space between the left border and the leftmost pixels of the text»
I need this option too.

image

Would you please reopen this issue?

@sasumner
Copy link
Contributor

It appears that there IS an existing Scintilla call for this that I overlooked:

https://www.scintilla.org/ScintillaDoc.html#SCI_SETMARGINLEFT

So I'll remove the "Scintilla dependent" label.

While I can't imagine why existing behavior would bother someone, that's just MO.

I'll reopen and I'll see what I can do for this.

@sasumner sasumner reopened this Oct 15, 2020
@sasumner sasumner self-assigned this Oct 15, 2020
@sasumner
Copy link
Contributor

Also between the top of the window and the topmost pixel of text

I've still no idea how that could be done -- ideas from anyone?

And between the cursor and the character to its left...

Or this?

@sasumner sasumner removed the scintilla dependent Can't be considered for N++ implementation unless/until Scintilla changes label Oct 15, 2020
@sasumner
Copy link
Contributor

It doesn't look all that great when text is selected:

image

And, BTW, notepad.exe doesn't have anywhere near the big "gap" that @NoneGiven posted a screenshot of earlier; here's my experience with it:

image

@morozover
Copy link

morozover commented Oct 15, 2020

In Windows 7 Notepad has gap of 1 mm:

image

@sasumner
Copy link
Contributor

@morozover Hmm, 1mm, I have visions of you holding a ruler up to your screen...

I'm thinking that this would have to have a preference setting controlling it, because I'm sure it will be either a users-love-it or users-hate it kind of thing.

I'm thinking a checkbox turns it on or off.
For users that need more "granularity" than that, they leave it off and set it via plugin.

I'm thinking the preference belongs on the new Margin/Border/Edge sub-page in Preferences, so this issue will be dependent upon #8896 being done first.

@sasumner
Copy link
Contributor

sasumner commented Feb 23, 2021

@donho, what's your feeling about this?

It has also come up a few times in the Community: https://community.notepad-plus-plus.org/topic/20157/how-to-add-a-gap-between-letters-and-border-of-n-window/

@donho
Copy link
Member

donho commented Apr 7, 2021

@sasumner
Yes, it's possible. Scintilla allows to set margin between border & text (for 2 sides - left & right, if my recall is good).
I wanted to implement then I forgot as always :)
I'll try to find the API and implement it.

edit: just saw that you assigned yourself - go ahead if you wanna do it, but let's talk about the settings for this feature (2 sides) before you begin.

edit2: Both document map & document peeker should be aligned with 2 main editors' settings regarding this feature.

@donho donho added the accepted label Apr 7, 2021
@donho donho self-assigned this Apr 7, 2021
@donho
Copy link
Member

donho commented Apr 7, 2021

I assign this issue to myself also so I can refind it easily.

@sasumner
Copy link
Contributor

sasumner commented Apr 7, 2021

@donho You go ahead with this one.

@sasumner sasumner removed their assignment Apr 7, 2021
@donho donho closed this as completed in 1a9307b Apr 11, 2021
@fml2
Copy link

fml2 commented Apr 12, 2021

Scintilla does not provide an option for the top gap. But it could be possibly implemented by rendering the scinitilla component a bit lower. This is just an assumption, I have not checked it.

@sasumner
Copy link
Contributor

Scintilla does not provide an option for the top gap. But it could be possibly implemented by rendering the scinitilla component a bit lower. This is just an assumption, I have not checked it.

I cannot see anybody wanting to put that kind of effort into achieving it.

@fml2
Copy link

fml2 commented Apr 12, 2021

Yes, absolutely true!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants