-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foreground Color of selected text cannot be changed #3397
Comments
i would like to work on this project.Can you please tell me what kind of programming languages i have to known for start this? |
Tow years passed, the issue remains in 7.7.1, and no one gives an explanation or fixes it. In your screenshot, the "foreground colour" option is disabled, which looks impossiable to change. In my NotePad++(7.7.1), the "foreground colour" option is enabled, but Nothing happend after change it. However, I do not think this is an issue. It's reasonable that not changing the foreground colour of selected text because the foreground colour indicate the type of the text, and changing the background colour can already make the seleced text clear enough to see. Thus the selected text should not has its own foreground colour and the "foreground colour" option should remain disabled. |
I am used to seeing the selected text with a solid background color and the text foreground in white, so I would still like to see the foreground text color configurable. While selecting text, it's not necessary for me to still see the syntax coloring as I'm simply selecting text for some action. I only need to retain syntax coloring when viewing the text or typing. I feel like it's fairly standard to see white text on a dark (blue usually) background when selecting text and I'd like to see NPP follow this widely-accepted practice. |
I think this option should definitely be implemented. I like the look of regular Windows Notepad, and when you highlight text there the background becomes a blue and the foreground becomes white text (which makes it easier to see it). I see no reason this shouldn't be an option. |
This problem still persists in 7.9.1, but the "Foreground Color" is enabled now, it just doesn't do anything. |
Probably best to write continuing comments against the version that is current as of this writing, and that is 7.9.3. Anyway, if I run 7.9.3, Foreground Colour for Selected text colour is not enabled: |
Weird. I just ran "Update" and it gave me 7.9.1 and says no update is available. But I guess that's another issue entirely. |
|
That article uses the wrong version of "which", does the manual have a GitHub as well? Sorry if this sounds like a grammar nazi type thing, I figure if we correct it it can look a little more professional :) |
Yeah, I just updated manually. The selector is still enabled on 7.9.3, too, though. |
@FireController1847 said:
I agree that section is a bit rough. |
It's cool to select text w/o losing the syntax highlighting. |
So.... What? Why? I don't understand how current functionality would be lost. If you keep the option transparent or disabled then use the current functionality, otherwise change the color. What's wrong with giving the preference? This is a basic functionality of Notepad in the first place. It makes highlighting even more clear. |
So this issue and others of its type will no longer be considered as the Notepad++ author has made a final decision not to support it. That decision is documented here: #9817 (comment) Any new issues on this topic will be immediately closed with a link to the final decision. |
[REDACTED] |
@FireController1847 |
In what world does giving users more options cause unbelievable changes. Never was this issue implying the feature should be replaced. The PR maybe overidded it, but the issue was not claiming that. If you would prefer I would make another issue more directly worded stating we would like it as an OPTIONAL feature. I don't, I truly don't understand how you think this will override the existing feature in the first place. As I described in my previous comment the potential solution... Whatever, this is fruitless, "THE DEVELOPER HAS SPOKEN" strikes again in an open-source project. |
I'm not really for adding more UI options for it, as we know "A lot of options, no option". |
That does sound like a reasonable compromise. I just ship my package as a theme compiled ZIP, so I wouldn't mind having to edit the hidden option. Thanks for being willing. |
@rcdailey |
@donho Sorry for my attitude earlier. Was having a rough morning. Thanks for doing this, I'll test it out next chance I get |
Not to belabor a negative, but we've seen this kind of comment a few times:
And I don't understand it, because it's the developer's project, and he has sole discretion about what happens with his project. Often people open an issue and it gets declined and they get rather perturbed about it. |
Don't forget to create an issue for the user manual so that you can describe your newly implemented behavior. |
@sasumner Oh no worries there. I think the primary reason this is a frustration is that usually when things like this happen the developer is unwilling to even discuss the issue or debate or even compromise like Donho did. Often it's just, "No, I'm not doing this and that's final." To make it even more frustrating many developers will lock the conversation if it continues. I totally get saying something like that after discussing for a bit and then if people are unwilling to compromise closing and locking the issue. But if a feature is rejected, I get that too but don't be so stubborn to not even discuss it or debate it, if you kind of know what I mean. At that point, why even make it open source, just use an issue tracker (yes, I know it's not just this simple and there's other reasons, but this is a huge primary reason.) And yeah, I agree it is the developer's project and ultimately up to them, but when I said "THE DEVELOPER HAS SPOKEN" I mostly meant like another case of unwillingness to compromise and stubbornness, as many open source developers are. I know this really isn't the place to discuss this so if you're more interested in my perspective add me on Discord I'd love to have a respectful, adult-like debate. I'm FireController1847#3577 |
@FireController1847 |
There has been a |
Finally, is there a way or hidden way or trick to change "Selected Text Foreground Colour"? |
There is indeed. See https://npp-user-manual.org/docs/config-files/#:~:text=enableSelectFgColor.xml |
Many thanks. |
Description of the Issue
Notepad++ does not use the standard selected text colors of white text on blue background. Because of this, the user should be able to change both the foreground and background colors of selected text. However, using the Style Configurator and changing the Foreground Color of selected text does nothing and the color is always black.
Steps to Reproduce the Issue
Expected Behavior
The foreground text color of selected text should change. Alternatively, the default secret text color should be the Windows standard OD white text on blue background.
Actual Behavior
The foreground text color of selected text does not change.
Debug Information
Notepad++ v7.4.1 (64-bit)
Build time : May 18 2017 - 02:02:28
Path : C:\Program Files\Notepad++\notepad++.exe
Admin mode : OFF
Local Conf mode : OFF
OS : Windows 7 (64-bit)
Plugins : DSpellCheck.dll mimeTools.dll NppConverter.dll PluginManager.dll
The color of the selected text in the npp dialog boxes as shown below is the windows standard and should be available in the npp editor.
![2017-06-13_212346](https://user-images.githubusercontent.com/25157703/27111916-8a87d972-5081-11e7-80b9-3abb218b3329.png)
The text was updated successfully, but these errors were encountered: