Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix the tab visuals #4578

Open
XeonG opened this issue Jun 12, 2018 · 8 comments
Open

Please fix the tab visuals #4578

XeonG opened this issue Jun 12, 2018 · 8 comments

Comments

@XeonG
Copy link

XeonG commented Jun 12, 2018

Currently the newer versions of notepad++ have an issue with all tabs and the overlay line on tabs that has some sort of ugly indenting happening on all the tabs as soon as the tabbar goes onto a 2nd row.

If the tabs are only on a single row it looks like normal (ie normal ugly like it was for years and years, now its just extra ugly)

This issue never used to happen in earlier versions of notepad++ (I hadn't upgraded in a while)

Personally would be really nice if the tab style customization was a lot better, and more configurable from the settings panel (like just basic tab coloring, and that yellow strip for active tab customizable)

@sasumner
Copy link
Contributor

Probably would help to add some screenshots with indications of exactly what you think is ugly about this...ugly is pretty subjective.

@XeonG
Copy link
Author

XeonG commented Jun 14, 2018

Here are the before and after, can see that when the tabs go onto the 2nd row, the style on the active tab changes to have this indenting going on (top/left borders are darker), and the bottom row of tabs gain an extra 1-2 pixel border around them.. doesn't happen with a single row tabbar, though that seems to reduce by 1px at the top, when there is another tab row below... its all bit messy (trivial but considering it looked a tad better how it worked before with so little improvements actually happening with notepad++ I just can't overlook it)

single row

multitab row)

@dinkumoil
Copy link
Contributor

dinkumoil commented Jun 14, 2018

I was able to find the reason for this behaviour with the help of WinSpy++.

In single-row-mode the TCS_BUTTONS bit of the tabbar's WindowStyle bitmask is not set. In multi-row-mode this bit is set, thus the tabs are drawn like buttons what's causing the effect mentioned above.

Neither I'm a C++ developer nor do I use VisualStudio, so I'm not able to fix this issue.

@MAPJe71
Copy link
Contributor

MAPJe71 commented Jun 14, 2018

See #1787 and #3016.

@dinkumoil
Copy link
Contributor

OK, according to this comment this issue isn't possible to fix. Functionality beats design.

@XeonG
Copy link
Author

XeonG commented Jun 14, 2018

I hadn't noticed the tab reordering thing being fixed (since updating I've mainly kept tab row to just single line because it looks damn ugly on multiline rows now)

Sure functionality over design, I don't mind that, but can nothing be done to style this better.... and keep the tab ordering fixes, instead of whoever hacked in the fix and broke the consistency of the tab styling.

Or go even further with a skinnable gui ...I mean notepad++ could really do with one. Where the gui and code theme can actually match. I could never get trying to use a darker code theme (even if I liked one) when the entire gui around it is windows theme toolbar colors etc....

And I mean I literately only used notepad++ for the longest time because it has multiline tab rows.. so useful even if the tab ordering was a bit broken, I just got used to it. I'd be using vscode completely now though, if it wasn't for MS being so damn slow at adding better TAB support and and multiline rows already, instead of forcing users to use some dumb extra sidebar just to work with lots of 'tabs' that stupidly get hidden off the tabbar because some idiots at MS think that is better design.. it is not.. rather have multiline tab rows with tabs and least a couple of characters for the document filename for all files visible anyday.

@LAPIII
Copy link

LAPIII commented Dec 20, 2019

@XeonG Can you please tell me how you got the title bar to be black?

@ArkadiuszMichalski
Copy link
Contributor

Same/simillar to #3181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants