Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?/FR] "Find in Files" results not visible in results pane for long lines #9879

Open
JC3 opened this issue May 16, 2021 · 0 comments
Open

Comments

@JC3
Copy link

JC3 commented May 16, 2021

Description of the Issue

For files with very long lines -- e.g. obfuscated JavaScript files with no line breaks -- the "Find In Files" results pane truncates the line before the location of the actual match, more often than not causing it to hide the search results.

Double-clicking the results does highlight the result and move the cursor to its location in the editor, so that part is good. However, it's not always possible to see the results in the results pane itself: You have to select each individual result so that it becomes visible in the editor, which can be a workflow issue when there are a lot of results.

Steps to Reproduce the Issue

  1. Use the "Find in Files" feature to search a source file or directory where the file(s) have very long lines and a lot of results.
  2. In the results pane, observe the long lines, scroll all the way right to see where they are truncated.

Current Behavior

The location / context of the results is not visible in the results pane.

Proposed Behavior

One option could be to also truncate the beginning of large lines, so that the result (with surrounding context) appears in the section of the line that the results pane displays.

And, personally, I wouldn't mind if the lines were truncated (left and right side) in such a way that horizontal scrolling was no longer needed in the results pane at all; i.e. center on match and truncate to window width. But that'd just be icing on the cake; I don't know what the best option is, really.

Example:

npppp.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant