Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List / Sub list default rendering does not render nested list items underneath checkable list item correctly #291

Closed
6 tasks
MFlisar opened this issue Sep 2, 2020 · 3 comments

Comments

@MFlisar
Copy link

MFlisar commented Sep 2, 2020

Infos

  • Markwon version: 4.5.1

Please specify expected/actual behavior

Here's a small example and how it renders inside github (which is what I expect):

  • Task 1
  • Task 2
  • Task 3
    • Sub Task 3.1
    • Sub Task 3.2
  • Task 4
    • Sub Task 3.1
    • Sub Task 3.2

And this is how it renders inside markwon with default implementations:

markwon test

Problem

The sub tasks that are not checkable should not add spaces above/below them and they should be intended - just like the sub tasks that are checkable do

@noties
Copy link
Owner

noties commented Sep 2, 2020

Hello @MFlisar ,

this happens because there is a difference in implementations. Markwon does not parse task list items as part of lists. This is why they cannot nest other lists and could not be nested inside other lists. I think we should align with how Github renders them (at least as long as commonmark specification does not include them).

I'm going to schedule this change to the next release

@MFlisar
Copy link
Author

MFlisar commented Sep 3, 2020

I'm going to schedule this change to the next release

Great news for me, thanks a lot

@noties
Copy link
Owner

noties commented Oct 5, 2020

Fixed in 4.6.0

@noties noties closed this as completed Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants