Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: package novu/web:0.10.0 broken #2413

Closed
2 tasks done
razorness opened this issue Jan 2, 2023 · 3 comments
Closed
2 tasks done

🐛 Bug Report: package novu/web:0.10.0 broken #2413

razorness opened this issue Jan 2, 2023 · 3 comments

Comments

@razorness
Copy link

razorness commented Jan 2, 2023

📜 Description

ghcr.io/novuhq/novu/web:0.10.0 is broken which is probably caused by CLRF line endings instead of LF.

👟 Reproduction steps

Follow your quick start guide:
https://github.com/novuhq/novu/tree/next/docker#quick-start

👍 Expected behavior

A running image.

👎 Actual Behavior with Screenshots

Log:

2023-01-02 19:21:26 
2023-01-02 19:21:26 > novuhq@ start:static:web /usr/src/app
2023-01-02 19:21:26 > cross-env nx run-many --target=start:static:build --projects=@novu/web
2023-01-02 19:21:26 
2023-01-02 19:21:28 
2023-01-02 19:21:28  >  NX   Running target start:static:build for 1 project(s):
2023-01-02 19:21:28 
2023-01-02 19:21:28     - @novu/web
2023-01-02 19:21:28 
2023-01-02 19:21:28  
2023-01-02 19:21:31 
2023-01-02 19:21:31 > nx run @novu/web:"start:static:build"
2023-01-02 19:21:31 
2023-01-02 19:21:31 
2023-01-02 19:21:31 > @novu/web@0.10.0 start:static:build /usr/src/app/apps/web
2023-01-02 19:21:31 > pnpm envsetup:docker && http-server build -p 4200 --proxy http://localhost:4200?
2023-01-02 19:21:31 
2023-01-02 19:21:31 
2023-01-02 19:21:31 > @novu/web@0.10.0 envsetup:docker /usr/src/app/apps/web
2023-01-02 19:21:31 > chmod +x ./env.sh && ./env.sh && mv ./env-config.js ./build/env-config.js
2023-01-02 19:21:31 
2023-01-02 19:21:28 /bin/sh: git: not found
2023-01-02 19:21:31 /bin/sh: git: not found
2023-01-02 19:21:31 sh: ./env.sh: not found
2023-01-02 19:21:31  ELIFECYCLE  Command failed.
2023-01-02 19:21:31  ELIFECYCLE  Command failed with exit code 1.
2023-01-02 19:21:31 
2023-01-02 19:21:31  
2023-01-02 19:21:31 
2023-01-02 19:21:31  >  NX   Running target "start:static:build" failed
2023-01-02 19:21:31 
2023-01-02 19:21:31    Failed tasks:
2023-01-02 19:21:31    
2023-01-02 19:21:31    - @novu/web:start:static:build
2023-01-02 19:21:31 
2023-01-02 19:21:31    See Nx Cloud run details at https://cloud.nx.app/runs/EBXRW2RBZv
2023-01-02 19:21:31 
2023-01-02 19:21:31  ELIFECYCLE  Command failed with exit code 1.

See sh: ./env.sh: not found which is an indicator that sh is not able to handle CRLF.
Was able to reproduce error when setting line endings of env.sh to CRLF while running docker:build.

🤖 Node Version

not involved

📃 Provide any additional context for the Bug.

Friendly reminder to avoid CRLF where possible.

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to submit PR?

None

@razorness razorness changed the title 🐛 Bug Report: bad line endings in apps/web/env.sh 🐛 Bug Report: package novu/web:0.10.0 broken Jan 2, 2023
@kAutoman
Copy link

kAutoman commented Jan 3, 2023

Any update for this issue?
I'm facing same error.
image

@razorness
Copy link
Author

For now, you can checkout tag/v0.10.0, go to folder apps/web and exec pnpm docker:build in WSL2 to have a running image to be used with docker-compose.
Image name will be novu-web:latest.

Ensure to have autocrfl disabled in your git config.

@scopsy
Copy link
Contributor

scopsy commented Jan 6, 2023

Was also resolved in the latest 0.10.1 🙏🎉

@scopsy scopsy closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants