refactor: remove default attempts #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopsy
approved these changes
Jan 3, 2023
| await this.queue.add(id, data, options); | ||
| } | ||
|
|
||
| private stepContainsFilter(data: JobEntity, onFilter: string) { | ||
| return data.step.filters.some((filter) => { |
There was a problem hiding this comment.
Suggested change
| return data.step.filters.some((filter) => { | |
| return data.step.filters?.some((filter) => { |
I think this causes the tests to fail, when no filters are available on a step
There was a problem hiding this comment.
Yeah, it is part of the issue I already have it locally but the test still fails, I am looking into it maybe there is another issue.
There was a problem hiding this comment.
Nope it probably was this one (the confusion on my side was due to the failing localstack locally + jobs from the previous run that was not handled)
scopsy
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
In order to remove the default attempts on the queue.
Other information (Screenshots)