Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of http proxy in option #33

Closed
KeanuPang opened this issue Oct 25, 2017 · 4 comments
Closed

Support of http proxy in option #33

KeanuPang opened this issue Oct 25, 2017 · 4 comments

Comments

@KeanuPang
Copy link

In node-fetch, we can pass a http.Agent with custom proxy settings in options with node-https-proxy-agent.

So maybe we can set http/https proxy settings in option from NotifmeSdk or read from environment variables like http_proxy and https_proxy, then all providers just read this option and pass it to node-fetch.

ref:
node-fetch/node-fetch#79
node-fetch/node-fetch#195

@BDav24
Copy link
Member

BDav24 commented Oct 25, 2017

Ok, I'll look into it.

@BDav24
Copy link
Member

BDav24 commented Oct 26, 2017

@KeanuPang You can now pass a NOTIFME_HTTP_PROXY env variable. If it's set, it'll create a node-https-proxy-agent.

#34
https://github.com/notifme/notifme-sdk/releases/tag/v1.6.0

@BDav24 BDav24 closed this as completed Oct 26, 2017
@KeanuPang
Copy link
Author

It's great works, I love this library notifme. Thank you.

@BDav24
Copy link
Member

BDav24 commented Oct 30, 2017

@KeanuPang
Thanks, I'm glad to hear that.
If I may ask, could you tell me how you use this lib? (context, providers...) It's useful to know in order to improve it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants