Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11

Merged
merged 2 commits into from
May 9, 2015
Merged

Fixes #11

merged 2 commits into from
May 9, 2015

Conversation

blaenk
Copy link
Contributor

@blaenk blaenk commented May 8, 2015

Switch to crates.io bitflags cause the one in rustc seems broken.

There's also a deprecation warning about using modified(). Not sure how to go about getting the modified time in a cross-platform manner. I think we'd have to define our own functions with a different implementation using the cfg attr. I'll leave that to you though.

src/poll.rs:51:55: 51:65 warning: use of deprecated item: use os::platform::fs::MetadataExt extension traits, #[warn(deprecated)] on by default
src/poll.rs:51               match mtimes.insert(watch.clone(), stat.modified()) {
                                                                     ^~~~~~~~~~
src/poll.rs:54:27: 54:37 warning: use of deprecated item: use os::platform::fs::MetadataExt extension traits, #[warn(deprecated)] on by default
src/poll.rs:54                   if stat.modified() > old {
                                         ^~~~~~~~~~
src/poll.rs:91:64: 91:74 warning: use of deprecated item: use os::platform::fs::MetadataExt extension traits, #[warn(deprecated)] on by default
src/poll.rs:91                         match mtimes.insert(path.clone(), stat.modified()) {
                                                                              ^~~~~~~~~~
src/poll.rs:94:37: 94:47 warning: use of deprecated item: use os::platform::fs::MetadataExt extension traits, #[warn(deprecated)] on by default
src/poll.rs:94                             if stat.modified() > old {
                                                   ^~~~~~~~~~

@blaenk
Copy link
Contributor Author

blaenk commented May 8, 2015

regarding the modified() calls, we can fix that in the future by using filetime.

@passcod
Copy link
Member

passcod commented May 9, 2015

This is great :) Next weekend I have allocated time to actually do Rust things (no, it's not a coincidence that it falls on the release of Rust 1.0 ;P), so I'll look into all the little things then.

passcod added a commit that referenced this pull request May 9, 2015
@passcod passcod merged commit f40b32f into notify-rs:master May 9, 2015
@blaenk
Copy link
Contributor Author

blaenk commented May 9, 2015

Sweet. If you could release a version with these fixes in the meantime I would appreciate it!

@passcod
Copy link
Member

passcod commented May 9, 2015

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants