Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: kqueue support based on polling crate #327

Closed
xanderio opened this issue Jun 4, 2021 · 2 comments
Closed

Proposal: kqueue support based on polling crate #327

xanderio opened this issue Jun 4, 2021 · 2 comments
Labels
B-duplicate os-bsd os-mac Z-needs implementation Needs an implementation, will accept PRs

Comments

@xanderio
Copy link
Contributor

xanderio commented Jun 4, 2021

I'm currently looking into adding support for kqueue to support BSD platforms.

After a bit of digging i found the polling crate from the smol-rs team.
The crate it self lists macOS, iOS, FreeBSD, NetBSD, OpenBSD, and DragonFly BSD as supported platforms for kqueue.

Would PR adding polling based KqueueWatcher be accepted?

@0xpr03
Copy link
Member

0xpr03 commented Jun 4, 2021

Yep, see #273 (and also here for all the kqueue mentions about better support through that ;) )

@0xpr03 0xpr03 added B-duplicate Z-needs implementation Needs an implementation, will accept PRs os-bsd os-mac labels Jun 4, 2021
@0xpr03
Copy link
Member

0xpr03 commented Jun 4, 2021

A bit of warning though: The current structure/implementation for the other systems is a little bit blurry as some stuff got changed/removed without a real new replacement. See for example here. It's totally fine if you just copy the feature parity of the inotify implementation (for which I can speak) and not implement for example the precise config optionality. Still I'd welcome some hints in the code for unsafe for why it's safe and also where you'd have to flip something to reach/implement unprecise* events.

* With unprecise I mean the PreciseEvents option we want to reach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-duplicate os-bsd os-mac Z-needs implementation Needs an implementation, will accept PRs
Projects
None yet
Development

No branches or pull requests

2 participants