feat: display formatted errors. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| format!("{}", | ||
| Error::Io(io::Error::new(io::ErrorKind::Other, expected)) | ||
| ) | ||
| ); |
There was a problem hiding this comment.
There's some kind of indentation mistake here. Also, the rest of the code is indented 2 chars, not 4.
There was a problem hiding this comment.
Ooops I am used to ident that way by the (still under development) style guide. Let me fix it. :)
There was a problem hiding this comment.
Yeah I want to change rsnotify to the rust style some day, but for now 'll just keep it consistent.
|
Looks good, thank you :) |
|
Thank you for this lib. I am using it in one of my projects and it is helping a lot! |
|
Glad you like it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there.
I've implemented the trait Display for the enum errors. That way we can display formatted messages for users when necessary instead of the debug version.
Feel free to review.
Cheers!