Support watching the same inode through multiple paths. #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a single change event can now refer to multiple paths, use "path groups" for renames to differentiate sources and destinations. Fixes notify-rs#572.
hugwijst
commented
Mar 8, 2024
| /// in distinct groups. | ||
| /// | ||
| /// If there are different path groups, the `path_group_split_index` attribute indicates the | ||
| /// first index with paths in the second group. | ||
| pub paths: Vec<PathBuf>, |
There was a problem hiding this comment.
As this is a behavioral change, we probably want some kind of API change so users explicitly decide how to handle multiple paths in one group, or this newly introduced concept of 2 different groups.
I didn't want to break this into two separate vectors, as to not increase the size of the Event struct. Maybe we should make paths private and have a fn path_groups(&self) -> (&[PathBuf], Option<&[PathBuf]>) method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support watching the same inode through multiple paths.
As a single change event can now refer to multiple paths, use "path groups" for renames to differentiate sources and destinations.
Fixes #572.