-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
does inotify leak when monitored objects are deleted? #61
Comments
That sounds right |
When this happens, should we also notify the user? How? |
@passcod you mean in addition to the REMOVE event? We could deliver and IGNORE event as well. |
The way we'd discover this in rsnotify ourselves is itself a notification. That is, |
Right, no, just sticking to the current events should be fine :) |
I'm wondering what happens if a monitored object is deleted. I'm wondering if it would remain/leak/linger in the
watches
map. Perhaps we can watch for theIN_DELETE_SELF
event for each watched path, and if triggered, we remove the entries? Not sure if that'd work.Also from TLPI:
So I think monitoring for
IN_IGNORED
should be enough. When we receive it, we remove the entries from our own data structures.The text was updated successfully, but these errors were encountered: