Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crash] Manual Installation is broken? #684

Open
Davoleo opened this issue Jan 1, 2022 · 3 comments
Open

[Crash] Manual Installation is broken? #684

Davoleo opened this issue Jan 1, 2022 · 3 comments
Labels
awaiting release This has already been dealt with but is not yet available bug Something isn't working right

Comments

@Davoleo
Copy link

Davoleo commented Jan 1, 2022

What is happening?
Notion doesn't start but crashes with JavaScript error after applying notion-enhancer

What should be happening?
Notion should be launched correctly

Screenshots (if applicable):
image

Operating system/browser name & version: Windows 10 21H2

notion-enhancer and/or notion-repackaged version: notion-enhancer/0.11.0 win32-x64/10.0.19044 node/v16.9.0

@Davoleo Davoleo added the bug Something isn't working right label Jan 1, 2022
@dragonwocky
Copy link
Member

can't currently be solved, it's a bug. until it's fixed use the notion-repackaged installation instead @SalemNabeelSalem

@faraazb
Copy link

faraazb commented Jan 4, 2022

I can get it to work by editing this line to fix the inserted require statement as

`\n\n//notion-enhancer\nrequire('notion-enhancer')('${target.replace(/\\/g, "/")}', exports, (js) => eval(js))`
// target.replace(/\\/g, "\\\\")} would also work I guess

I don't know if this is the best way but it shouldn't affect other platforms.

@miozus
Copy link

miozus commented Jan 17, 2022

update: I got a method to use it after 1 month past.

before:

circle-forever

require :

backslash \ ⇒ slash /

but Notion launched with circle round and round forever.

Not work on Windows 11 21H2 22000.434


after:

  1. npm install notion-enchaner & apply

notion-enhance-install

Don't modify any files after cmd notion-enhancer apply. Ignore what the bug notify message window while open Notion.exe.

  1. Just download Notion-enhancer.exe which called Installer under Windows part.

  2. Open with Notion-enhancer.exe from now on:

notion-enhancer

(ps. don't open with Notion.exe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This has already been dealt with but is not yet available bug Something isn't working right
Projects
None yet
Development

No branches or pull requests

5 participants
@dragonwocky @Davoleo @miozus @faraazb and others