Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The theme color needs to be update #615

Closed
Apolsus opened this issue Oct 12, 2021 · 8 comments
Closed

The theme color needs to be update #615

Apolsus opened this issue Oct 12, 2021 · 8 comments
Labels
awaiting release This has already been dealt with but is not yet available bug Something isn't working right

Comments

@Apolsus
Copy link

Apolsus commented Oct 12, 2021 •
edited

In version 2.12.23.10.11.1

Notion change lots of color and background. Therefore, the css selector in the theme mod fail to work.
@Apolsus Apolsus added the bug Something isn't working right label Oct 12, 2021
@dragonwocky dragonwocky added awaiting release This has already been dealt with but is not yet available duplicate This issue or pull request already exists and removed awaiting release This has already been dealt with but is not yet available labels Oct 12, 2021
@dragonwocky
Copy link
Member

the theming system has already been completed overhauled and is awaiting release. the majority of the code is this repo is outdated and will be replaced as soon as the rewrite is ready for use. it should not be used as a base for anything.

there are also already other issues about this e.g. #352

@dragonwocky
Copy link
Member

dragonwocky commented Oct 12, 2021 •
edited

reopening because there are new tags/text/background colours, I understand what you meant now. @l782993610 please include details (e.g. description of which colours have actually changed, screenshots) when opening issues otherwise they will always be closed. "theme colours no work" and then a giant copy/paste of CSS is not helpful

@dragonwocky dragonwocky reopened this Oct 12, 2021
@Apolsus
Copy link
Author

Apolsus commented Oct 12, 2021

All the text color and text background color rgb value is changed.
image

@dragonwocky
Copy link
Member

image
notion will continue changing this more. we just need to wait until they're done before we can update anything.

@dragonwocky dragonwocky removed the duplicate This issue or pull request already exists label Oct 15, 2021
@dragonwocky dragonwocky mentioned this issue Oct 15, 2021
Closed
@bjohas
Copy link

bjohas commented Oct 24, 2021

Hello - just wondering whether color changes to the themes should now be working or not? Or is this an issue for notion-enhancer/notion-repackaged#50 (which is now closed?)

@dragonwocky
Copy link
Member

@bjohas they will not be working until notion-enhancer v0.11.0 is released (which depends on how much time I have, cos exams, and how long notion takes, cos they keep changing things). The issue you referenced has been closed in favour of this one.

@bjohas
Copy link

bjohas commented Oct 24, 2021

Thank you, that's helpful to know!

@jahirfiquitiva
Copy link

Any chance of getting a quick fix for databases borders? 🙏

Shot 2021-10-25 at 18-24-44@2x

@dragonwocky dragonwocky added the awaiting release This has already been dealt with but is not yet available label Nov 30, 2021
@dragonwocky dragonwocky mentioned this issue Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting release This has already been dealt with but is not yet available bug Something isn't working right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bjohas @jahirfiquitiva @dragonwocky @Apolsus