Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing dependencies #7

Closed
dragonwocky opened this issue Jun 26, 2020 · 1 comment
Closed

removing dependencies #7

dragonwocky opened this issue Jun 26, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@dragonwocky
Copy link
Member

At the moment, the enhancer is in Python but sends a system call to the electron asar package in order to extract app files.

a) remove Node.js as a dependency and use the pyasar pip package.
b) remove Python as a dependency and rewrite in Node.js.

I've attempted a), but the pyasar package has not been updated for 4 years and just throws errors when I try to use it.
A rewrite would be necessary for #6 anyway - so, I'm going with b) unless someone has a better solution.

@dragonwocky
Copy link
Member Author

branch js going ahead with b, further discussion in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant