Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use build config with variables for both local and CI builds #12

Closed
jamezrin opened this issue Jul 12, 2021 · 0 comments
Closed

Use build config with variables for both local and CI builds #12

jamezrin opened this issue Jul 12, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@jamezrin
Copy link
Member

The idea is to have a file (notion-repackaged.env or notion-repackaged.sh) that has variables for things like the version and the revision, the upstream hash, notion-enhancer commit hash, etc.

This file should be used by the local build script and the CI pipeline. And the github actions workflow should only be triggered when a modification of this file is pushed to the repository https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestpaths

@jamezrin jamezrin added feature request enhancement New feature or request and removed feature request labels Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant