Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dig v2 #157

Closed
faddat opened this issue Jan 22, 2022 · 11 comments
Closed

dig v2 #157

faddat opened this issue Jan 22, 2022 · 11 comments

Comments

@faddat
Copy link
Collaborator

faddat commented Jan 22, 2022

Dig v2 is mainly a cleanup and scope reduction release.

  1. epochs did not work, let's take e'm out
  2. we really do need minimum commission fees. Notional was built on Notional's osmo commission fees and that's something that we want to see happen for Dig's validators.
  3. Cosmos-SDK v0.45.0

Dig community/team:

How many other state-breaking changes can we pack into v0.45.0?

:)

-J

@vuong177
Copy link
Contributor

I removed it in branch :

https://github.com/notional-labs/dig/tree/epoch-remove

@faddat
Copy link
Collaborator Author

faddat commented Jan 30, 2022

Any idea what upgrade handlers look like for this?

Let's make a checklist for the dig v2 upgrade:

  • Remove epochs
  • Enforce minimum commissions
  • Use canonical secp256k1 signing (let's not use modified cosmos-sdk anymore if possible)
  • CosmWasm
    • arm support
  • Upgrade Handlers
  • Version Import Paths
  • Testnet
  • Governance Proposal
  • Upgrade

@catShaark
Copy link
Contributor

yeah, I agree

@vuong177
Copy link
Contributor

vuong177 commented Feb 7, 2022

Enforce minimum commissions in branch : https://github.com/notional-labs/cosmos-sdk/tree/v0.45-1-rum

I think we should use a modify cosmos-sdk (don't use mainline cosmos-sdk)

@faddat
Copy link
Collaborator Author

faddat commented Feb 7, 2022

Why not use mainline?

Mainline now has minimum commissions.

Basiclally I'd like to use mainline for both the eth tx singing and for the minimum comissions. It seems better and safer to me, and will enable us to follow more closely for upgrades.

There's also better testing features upstream, too. I would definitely like to introduce a simulationmanager to app.go

@vuong177
Copy link
Contributor

vuong177 commented Feb 7, 2022

hmm, i don't see minimum comissions in cosmos-sdk v0.45.1
https://github.com/cosmos/cosmos-sdk/blob/v0.45.1/x/staking/types/staking.pb.go

@faddat
Copy link
Collaborator Author

faddat commented Feb 7, 2022

well 💩 Best fork off again, then.

Can you check this code against the mincomission code on juno?

An edge case was discovered and it was a bit nasty

@faddat faddat mentioned this issue Feb 7, 2022
@vuong177
Copy link
Contributor

Cosmwasm done. In https://github.com/notional-labs/dig/tree/digv2

I instance some contract and test with it. Contract work 💯

@catShaark
Copy link
Contributor

what is Version Import Paths

@nghuyenthevinh2000
Copy link
Contributor

@nguyenvuong1122000
What is dig testnet node? so I can set up faucet bot

@faddat
Copy link
Collaborator Author

faddat commented Mar 23, 2022

hey!

@faddat faddat closed this as completed Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants