Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eth-address on cli #82

Closed
1 task
nghuyenthevinh2000 opened this issue Nov 23, 2021 · 12 comments
Closed
1 task

add eth-address on cli #82

nghuyenthevinh2000 opened this issue Nov 23, 2021 · 12 comments

Comments

@nghuyenthevinh2000
Copy link
Contributor

nghuyenthevinh2000 commented Nov 23, 2021

The story is that modified keplr for dig has added support for eth address. But, it is not the same for cli.

Objective: "digd keys add temp" must return eth address instead of "dig1981hjrhewkrhqwr".

The library to convert. @romelukaku knows

  • extract which library from @romelukaku
@nghuyenthevinh2000
Copy link
Contributor Author

@nghuyenthevinh2000
I am working on this now

@faddat
Copy link
Collaborator

faddat commented Nov 28, 2021

Cool!

Please talk with Osmosis:

osmosis-labs/osmosis#590
osmosis-labs/osmosis#589

@faddat
Copy link
Collaborator

faddat commented Nov 28, 2021

@nghuyenthevinh2000 I would like dig1 addresses to be the primary though. Maybe have a flag letting you specify an eth address.

@nghuyenthevinh2000
Copy link
Contributor Author

thanks for the info, I will talk to them

@nghuyenthevinh2000
Copy link
Contributor Author

prodv2.tar.gz

@MasterPi-2124
Copy link
Contributor

ethsecp256k1 is supported on dig. See https://github.com/tharsis/ethermint/blob/main/crypto/ethsecp256k1/ethsecp256k1.go

digd keys add --algo ethsecp256k1

@MasterPi-2124
Copy link
Contributor

strangely that Minh's branch is working while main branch doesn't

@nghuyenthevinh2000
Copy link
Contributor Author

inconsistency in dig version that supports eth address gen

@vuong177
Copy link
Contributor

it's working in main branch now

@faddat
Copy link
Collaborator

faddat commented Dec 12, 2021

Ok, I am going to close this and please reopen if there are problems.

@faddat faddat closed this as completed Dec 12, 2021
@vuong177 vuong177 reopened this Dec 22, 2021
@vuong177
Copy link
Contributor

We need change eth code, to verify metamask signature.

@nghuyenthevinh2000
Copy link
Contributor Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants