Review

[m4rc1e]

I'm reviewing the diff reports generated in https://github.com/notofonts/arabic/actions/runs/4788911633

Noto Naskh:

Modified Glyphs:

before:

after:

Old form matches OS X default better

Missing glyphs:

Mark positions which seem suspect

Before:

After:

Otherwise LGTM. I'll look at the other as well.

[m4rc1e]

Khaled pointed out the Lam positioning in #186 (comment) as well.

[simoncozens]

The "filled damma" change in letter ۇ is deliberate; see #25.

[m4rc1e]

Noto Naskh Arabic UI

The hamza high now appear too big (I could be wrong), when compared to other system fonts.

before:

after:

otherwise LGTM

[m4rc1e]

Noto Sans Arabic

jeem dot looked better before

before:

after:

Looks like there may be contour direction issues for بھٲئی

before:

after:

otherwise LGTM

[m4rc1e]

@simoncozens please ignore any of my comments if they are intentional, I haven't checked any previous issues before conducting my checks. Everything looks much better!

[khaledhosny]

Noto Naskh Arabic UI

The hamza high now appear too big (I could be wrong), when compared to other system fonts.

before:

after:

otherwise LGTM

This is deliberate as well (in master they also gets the filled comma form), see #39.

[khaledhosny]

Noto Sans Arabic

jeem dot looked better before

before:

after:

Looks like there may be contour direction issues for بھٲئی

before:

after:

otherwise LGTM

Both issues are fixed now.