Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dagesh overlaps in heavier weights of Noto Sans Hebrew #47

Open
MAZ06 opened this issue Apr 9, 2024 · 6 comments
Open

Dagesh overlaps in heavier weights of Noto Sans Hebrew #47

MAZ06 opened this issue Apr 9, 2024 · 6 comments

Comments

@MAZ06
Copy link

MAZ06 commented Apr 9, 2024

Font

NotoSansHebrew[wdth,wght].ttf

Where the font came from, and when

https://github.com/notofonts/hebrew/releases/tag/NotoSansHebrew-v2.003

Font Version

Noto Sans Hebrew 2.003

OS name and version

Windows 11

Application name and version

Photoshop

Issue

The dagesh can sometimes overlap the next letter in the heavier weights as seen in the screenshots below. This seems to affect Black, SemiCondensed Black, Condensed Black, ExtraCondensed Black, Condensed ExtraBold, and ExtraCondensed ExtraBold.

Character data

יּה
U+05D9 י
U+05BC ּ
U+05D4 ה

Screenshot

image
Left: Black, SemiCondensed Black, Condensed Black, ExtraCondensed Black
Right: Condensed ExtraBold, ExtraCondensed ExtraBold

image

@MAZ06
Copy link
Author

MAZ06 commented Apr 22, 2024

@simoncozens It seems that this is not fully fixed.

The יּה works now, but יּע still does not.
image
image

@MAZ06
Copy link
Author

MAZ06 commented Apr 22, 2024

These too:
וּש
וּג
וּט
וּך
וּכ
וּס
וּף
וּפ
וּץ
image
image
image
image
image
image
image
image
image
יּע
יּש
יּג
יּט
יּכ
יּס
יּפ
יּץ
image

@MAZ06
Copy link
Author

MAZ06 commented Apr 22, 2024

And then these are cutting it pretty close:
וּם
וּמ
וּח
וּה
וּת
וּר
וּנ
וּן
image

@MAZ06
Copy link
Author

MAZ06 commented Apr 22, 2024

Almost every letter combination with yod and vav would have to have its own dagesh form if you're going to do it the way I saw in your code.

@simoncozens
Copy link
Contributor

I don't think I'm doing it the way you think I'm doing it. :-)

The dagesh combines with the yod/vav to make a "dagesh form", not the letter after it. We just need a bit of kerning on those two glyphs.

@simoncozens simoncozens reopened this Apr 22, 2024
@MAZ06
Copy link
Author

MAZ06 commented Apr 22, 2024

Apologies. I'm obviously not much of a coder. But thanks for reopening this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants