-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incomplete soft-dotting with intervening marks #64
Comments
@curya What application and what OS is this in? |
@moyogo Photoshop. Windows 10. |
In Adobe apps you may have to change the text engine being used. |
@moyogo It's incorrect in everything. Photoshop is just what I used to show it here. Noto Sans Medium, for example, works perfectly. |
@simoncozens Pinging you to make sure you see this. :) |
I see all Noto bug reports. :-) |
@curya Which files are you using exactly? What version and where did you get them? See the orginial issue post above. |
@curya Here’s i̠̥̽ẅ́r̢̡ in WordPad with googlefonts/ttf/NotoSans-Regular.ttf from NotoSans-v2.011.zip. All the other NotoSans-Regular.ttf or .otf and variable font files produce the same result in my test on Windows 11 22621.1413. |
@moyogo Sorry for the super late reply here, but I believe you were correct. For some reason, Photoshop installed Noto Sans version 1.*** and it was conflicting with my newer version.
|
Which Photoshop? In older versions of Photoshop, the default shaping engine didn't handle mark-to-mark positioning. At any rate, I don't think there is a problem with the font here; you can test by dropping the font onto Crowbar and typing in the text. If the shaping engine in an application doesn't work, that's bad, but it's not something we can fix. |
@simoncozens Newest Photoshop. Version 24.5. AFAIK, Photoshop uses Harfbuzz... I tried Crowbar and got the same issue: |
I think the issue is in the version of Noto Sans you're using. Latest from here: |
https://github.com/notofonts/latin-greek-cyrillic/releases/download/NotoSans-v2.012/NotoSans-v2.012.zip I tried the one you linked and got the exact same incorrect result. No idea why we're getting such different outcomes when using the exact same files. To add to this, I tried using Noto Serif and that one does work correctly: |
Oh, exasperated exclamation. You're right. It's something to do with the ufomerge build process. hinted/unhinted builds are fine, full/googlefonts are broken. |
I've fixed this in |
Font
NotoMono-Regular.otf
NotoSans-Regular.ttf
NotoSerif-Regular.ttf
Where the font came from, and when
Site: https://github.com/googlefonts/noto-fonts/blob/bf20559450ec75aec7a646b208343540a4496262/phaseIII_only/unhinted/otf/NotoMono/NotoMono-Regular.otf
Site: https://github.com/googlefonts/noto-fonts/blob/bf20559450ec75aec7a646b208343540a4496262/phaseIII_only/hinted/ttf/NotoSans/NotoSans-Regular.ttf
Site: https://github.com/googlefonts/noto-fonts/blob/bf20559450ec75aec7a646b208343540a4496262/phaseIII_only/hinted/ttf/NotoSerif/NotoSerif-Regular.ttf
Date: 2020-08-01
Font version
Noto Mono: Version 2.004
Noto Sans: Version 2.003; ttfautohint (v1.8.2)
Noto Serif: Version 2.003; ttfautohint (v1.8.2)
Issue
Soft dots are removed before a mark above only if there are fewer than two marks not above between the base and the above-base mark. They should be removed regardless of how many marks intervene. The simplest solution is for the lookup that removes soft dots to use a mark set of the above-base marks.
Character data
i̠̥̽
U+0069 LATIN SMALL LETTER I
U+0320 COMBINING MINUS SIGN BELOW
U+0325 COMBINING RING BELOW
U+033D COMBINING X ABOVE
Screenshot
The text was updated successfully, but these errors were encountered: