Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete soft-dotting with intervening marks #64

Closed
dscorbett opened this issue Aug 10, 2020 · 19 comments
Closed

Incomplete soft-dotting with intervening marks #64

dscorbett opened this issue Aug 10, 2020 · 19 comments
Assignees

Comments

@dscorbett
Copy link

Font

NotoMono-Regular.otf
NotoSans-Regular.ttf
NotoSerif-Regular.ttf

Where the font came from, and when

Site: https://github.com/googlefonts/noto-fonts/blob/bf20559450ec75aec7a646b208343540a4496262/phaseIII_only/unhinted/otf/NotoMono/NotoMono-Regular.otf
Site: https://github.com/googlefonts/noto-fonts/blob/bf20559450ec75aec7a646b208343540a4496262/phaseIII_only/hinted/ttf/NotoSans/NotoSans-Regular.ttf
Site: https://github.com/googlefonts/noto-fonts/blob/bf20559450ec75aec7a646b208343540a4496262/phaseIII_only/hinted/ttf/NotoSerif/NotoSerif-Regular.ttf
Date: 2020-08-01

Font version

Noto Mono: Version 2.004
Noto Sans: Version 2.003; ttfautohint (v1.8.2)
Noto Serif: Version 2.003; ttfautohint (v1.8.2)

Issue

Soft dots are removed before a mark above only if there are fewer than two marks not above between the base and the above-base mark. They should be removed regardless of how many marks intervene. The simplest solution is for the lookup that removes soft dots to use a mark set of the above-base marks.

Character data

i̠̥̽
U+0069 LATIN SMALL LETTER I
U+0320 COMBINING MINUS SIGN BELOW
U+0325 COMBINING RING BELOW
U+033D COMBINING X ABOVE

Screenshot

i̠̥̽i̠̥̽i̠̥̽

@nizarsq
Copy link

nizarsq commented Aug 19, 2020

Screen Shot 2020-08-18 at 9 14 57 PM

@simoncozens simoncozens transferred this issue from notofonts/noto-fonts Jun 20, 2022
@curya
Copy link

curya commented Mar 31, 2023

This is not fixed correctly in Noto Sans Regular.
image

@moyogo
Copy link
Contributor

moyogo commented Mar 31, 2023

@curya What application and what OS is this in?

@curya
Copy link

curya commented Mar 31, 2023

@moyogo Photoshop. Windows 10.

@moyogo
Copy link
Contributor

moyogo commented Mar 31, 2023

@moyogo Photoshop. Windows 10.

In Adobe apps you may have to change the text engine being used.
Have a look at https://helpx.adobe.com/lu_en/photoshop/using/arabic-hebrew.html

@curya
Copy link

curya commented Mar 31, 2023

@moyogo It's incorrect in everything. Photoshop is just what I used to show it here.

Noto Sans Medium, for example, works perfectly.

Noto Sans Medium:
image

@curya
Copy link

curya commented Apr 5, 2023

@simoncozens Pinging you to make sure you see this. :)

@simoncozens
Copy link
Contributor

I see all Noto bug reports. :-)

@simoncozens simoncozens reopened this Apr 5, 2023
@curya
Copy link

curya commented Apr 14, 2023

This could also be related to this issue? ẅ́
image

And r̢̡
image
image

@moyogo
Copy link
Contributor

moyogo commented Apr 15, 2023

@curya Which files are you using exactly? What version and where did you get them? See the orginial issue post above.

@moyogo
Copy link
Contributor

moyogo commented Apr 16, 2023

@curya Here’s i̠̥̽ẅ́r̢̡ in WordPad with googlefonts/ttf/NotoSans-Regular.ttf from NotoSans-v2.011.zip. All the other NotoSans-Regular.ttf or .otf and variable font files produce the same result in my test on Windows 11 22621.1413.
Screenshot 2023-04-16 at 05 14 11
Can you try opening services.msc and disable "Windows Fonts Cache", then uninstall and reinstall NotoSans-Regular.ttf (or the one you’re using)?

@curya
Copy link

curya commented May 25, 2023

@moyogo Sorry for the super late reply here, but I believe you were correct. For some reason, Photoshop installed Noto Sans version 1.*** and it was conflicting with my newer version.
@simoncozens Sorry for the trouble. This was merely user error (Photoshop error?).

image
This is what my Photoshop displays now with Noto Sans Regular 2.012. Is this correct? It doesn't look like what moyogo posted above. Could I have discovered another Photoshop problem with Noto Sans inadvertantly?

@simoncozens
Copy link
Contributor

Which Photoshop? In older versions of Photoshop, the default shaping engine didn't handle mark-to-mark positioning. At any rate, I don't think there is a problem with the font here; you can test by dropping the font onto Crowbar and typing in the text. If the shaping engine in an application doesn't work, that's bad, but it's not something we can fix.

@curya
Copy link

curya commented May 25, 2023

@simoncozens Newest Photoshop. Version 24.5. AFAIK, Photoshop uses Harfbuzz...

I tried Crowbar and got the same issue:
image
Looks like there is an issue...

@simoncozens
Copy link
Contributor

I think the issue is in the version of Noto Sans you're using. Latest from here:
Screenshot 2023-05-25 at 14 53 19

@curya
Copy link

curya commented May 25, 2023

https://github.com/notofonts/latin-greek-cyrillic/releases/download/NotoSans-v2.012/NotoSans-v2.012.zip
This is the one I was using.

I tried the one you linked and got the exact same incorrect result. No idea why we're getting such different outcomes when using the exact same files.

To add to this, I tried using Noto Serif and that one does work correctly:
image

@curya
Copy link

curya commented May 25, 2023

Update:
Noto Sans 2.011 works correctly!
image

Noto Sans 2.012 is where something went wrong:
image

@simoncozens
Copy link
Contributor

Oh, exasperated exclamation. You're right. It's something to do with the ufomerge build process. hinted/unhinted builds are fine, full/googlefonts are broken.

@simoncozens simoncozens reopened this May 25, 2023
@simoncozens
Copy link
Contributor

I've fixed this in ufomerge; it'll be fixed next time Noto Sans gets built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants