Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'dist' ignores marks that its rules would otherwise apply to #22

Open
dscorbett opened this issue Apr 1, 2023 · 1 comment
Open

'dist' ignores marks that its rules would otherwise apply to #22

dscorbett opened this issue Apr 1, 2023 · 1 comment

Comments

@dscorbett
Copy link

Fonts

NotoSansMalayalam-Regular.otf
NotoSerifMalayalam-Regular.otf

Where the fonts came from, and when

Site: https://github.com/notofonts/malayalam/releases/tag/NotoSansMalayalam-v2.104
Site: https://github.com/notofonts/malayalam/releases/tag/NotoSerifMalayalam-v2.104
Date: 2023-03-31

Font version

Version 2.104

Issue

'dist' ignores marks in these fonts, but some of the glyphs in its rules are mark glyphs, so the rules do not apply. 'dist' should only ignore non-spacing marks.

There should probably be a Font Bakery check to make sure no lookup ignores any glyphs that its rules would otherwise apply to.

Character data

ഺൄ
U+0D3A MALAYALAM LETTER TTTA
U+0D44 MALAYALAM VOWEL SIGN VOCALIC RR

Screenshots

ഺൄ
ഺൄ
Cf. the intended rendering:
ഺൄ
ഺൄ

@simoncozens
Copy link
Contributor

The weird thing is that since at least 2.101, the dist feature has looked like this:

pos .notdef .notdef 0

There are some dist lookups in the prefix, but they're not connected to anything in the feature list. 2.001 had a working dist feature. We lost it all when we converted the Monotype sources to AFDKO.

I don't know whether to drop the subsidiary lookups or try to restore the original 2.001 dist feature. I don't know if it's actually a problem or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants