Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glyph overlap issue with USE #1

Closed
khaledhosny opened this issue Jul 15, 2022 · 3 comments
Closed

Glyph overlap issue with USE #1

khaledhosny opened this issue Jul 15, 2022 · 3 comments

Comments

@khaledhosny
Copy link

khaledhosny commented Jul 15, 2022

Defect Report

Glyph overlap issue

The version of Noto Sans Sinhala from this repository have some glyph overlaps issue, compared to the version from https://fonts.google.com/noto/specimen/Noto+Sans+Sinhala when shaped with USE.

Font

NotoSansSinhala/unhinted/ttf/NotoSansSinhala-Regular.ttf

Where the font came from, and when

https://github.com/notofonts/sinhala/releases/tag/NotoSansSinhala-v2.005

Issue

With HarfBuzz >= 4.4.0 (where Sinhala is shaped through USE) and the font from the repo:

hb-view NotoSansSinhala/unhinted/variable-ttf/NotoSansSinhala\[wdth\,wght\].ttf "ශ්‍රී ලංකාවේ ප්‍රධාන ජාතිය"

Compared to the font from GF:

hb-view Noto_Sans_Sinhala/NotoSansSinhala-VariableFont_wdth\,wght.ttf"ශ්‍රී ලංකාවේ ප්‍රධාන ජාතිය"

DirectWrite output is similar to HarfBuzz in both cases.

@khaledhosny
Copy link
Author

I found this while debugging harfbuzz/harfbuzz#3725

@simoncozens
Copy link
Contributor

The obvious big-hammer fix would be to reclassify the spacing marks as bases, to stop the width zeroing. We really want to be able to support both USE and pre-USE shapers.

@simoncozens
Copy link
Contributor

I've fixed this by making them all bases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants