Skip to content

"TOCTOU" in instchown.c #263

Closed
Closed

Description

@schmonz

The Security tab shows a few TOCTOU in instchown.c. I vaguely recall having seen and discussed this before, but can't find it. Worth taking the analyzer's advice, or should we dismiss the alerts?

Activity

  1. added this to the 1.09 milestone on Feb 1, 2024
  2. added
    bugSomething isn't working
    help wantedExtra attention is needed
    on Feb 2, 2024
  3. linked a pull request that will close this issueinstchown: operate on fds, not filenames. #266on Feb 2, 2024
  4. DerDakon commented on Feb 3, 2024

    @DerDakon
    Member

    No, this is totally pointless. These are files we just installed. And I can't find a check of existence at the place this is pointing to, it is just doing chown() and reports error And before it does chmod() and reports error..

  5. changed the title [-]TOCTOU in instchown.c[/-] [+]"TOCTOU" in instchown.c[/+] on Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions