Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #37

Closed
notrab opened this issue Jun 11, 2020 · 1 comment
Closed

Add tests #37

notrab opened this issue Jun 11, 2020 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@notrab
Copy link
Owner

notrab commented Jun 11, 2020 •
edited

Now more people are using this than just me, we should probably add some test coverage to improve reliability, and maybe seek out a few bugs.

Let's use @testing-library/react-hooks for this 馃ぉ
@notrab notrab added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 11, 2020
@notrab notrab mentioned this issue Jun 11, 2020
Merged
@notrab
Copy link
Owner Author

notrab commented Jun 14, 2020

I've gone ahead and added some minimal unit tests. It could be cleaned up significantly.

@notrab notrab mentioned this issue Jun 21, 2020
Merged
@notrab notrab closed this as completed Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@notrab