adafruit18fb: "green tab" version has extra random pixels on two edges

[notro]

According to the work of Kamal Mostafa, set_addr_win() has to be modified.
See: https://github.com/kamalmostafa/raspberrypi-linux/blob/rpi-3.2.27%2Bkamal-st7735fb/drivers/video/st7735fb/st7735fb.c

When I get the time, I will modify the driver by adding support for 2 devices so it can handle both versions.

[gitalicious]

Thanks. A quick test by hard-coding the offsets in fbtft_set_addr_win() appears to have worked for me.

write_cmd(par, FBTFT_CASET);
write_data(par, 0x00);
write_data(par, xs + 0x02);
write_data(par, 0x00);
write_data(par, xe + 0x02);
write_cmd(par, FBTFT_RASET);
write_data(par, 0x00);
write_data(par, ys + 0x01);
write_data(par, 0x00);
write_data(par, ye + 0x01);

[notro]

I have added support for the Green tab model: adafruit18greenfb.
Please report back if it works.

Diff: 6373b52

[gitalicious]

This is now working as far as I can tell... with no random pixels along the edge.

modprobe spidevices name=adafruit18greenfb

[notro]

Thanks for testing, I'll close this issue.

[sirdel]

Was working nicely up until I rotated by 90 deg :-
sudo modprobe fbtft_device name=adafruit18_green rotate=90
which causes the random pixels to appear.

Can be fixed by initialising without a rotation, removing the module and then inserting again with rotation :-
sudo modprobe fbtft_device name=adafruit18_green
sudo modprobe -r fbtft_device
sudo modprobe fbtft_device name=adafruit18_green rotate=90