Skip to content

Commit

Permalink
drop glew
Browse files Browse the repository at this point in the history
  • Loading branch information
notspiff committed Oct 31, 2016
1 parent e6be163 commit 11371c4
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 76 deletions.
9 changes: 3 additions & 6 deletions CMakeLists.txt
Expand Up @@ -19,11 +19,9 @@ if (NOT WIN32)
add_options(CXX ALL_BUILDS -std=c++11)
find_package(OpenGL)
if(OPENGL_FOUND)
find_package(GLEW REQUIRED)
set(INCLUDES ${OpenGL_INCLUDE_DIR}
${GLEW_INCLUDE_DIR})
set(INCLUDES ${OpenGL_INCLUDE_DIR})
add_definitions(-DHAS_OPENGL)
set(DEPLIBS ${DEPLIBS} ${OPENGL_LIBRARIES} ${GLEW_LIBRARIES})
set(DEPLIBS ${DEPLIBS} ${OPENGL_LIBRARIES})
else()
find_package(OpenGLES2)
if(OPENGLES2_FOUND)
Expand All @@ -36,7 +34,6 @@ if (NOT WIN32)
endif()

include_directories(${OpenGL_INCLUDE_DIR}
${GLEW_INCLUDE_DIR}
${KODI_INCLUDE_DIR}
${p8-platform_INCLUDE_DIRS}
${PROJECT_SOURCE_DIR}/lib/kissfft
Expand All @@ -45,7 +42,7 @@ if (NOT WIN32)
set(SHADERTOY_SOURCES src/lodepng.cpp
src/main.cpp)

set(DEPLIBS ${DEPLIBS} ${OPENGL_LIBRARIES} ${GLEW_LIBRARIES})
set(DEPLIBS ${DEPLIBS} ${OPENGL_LIBRARIES})

elseif(WIN32)
include_directories(${KODI_INCLUDE_DIR}
Expand Down
20 changes: 0 additions & 20 deletions FindGLEW.cmake

This file was deleted.

2 changes: 1 addition & 1 deletion debian/control
Expand Up @@ -2,7 +2,7 @@ Source: kodi-visualization-shadertoy
Priority: extra
Maintainer: wsnipex <wsnipex@a1.net>
Build-Depends: debhelper (>= 8.0.0), cmake, libp8-platform-dev, kodi-addon-dev,
kodi-visualization-dev, libgl1-mesa-dev, libglew-dev,
kodi-visualization-dev, libgl1-mesa-dev,
automake, autoconf, libtool
Standards-Version: 3.9.8
Section: libs
Expand Down
16 changes: 0 additions & 16 deletions depends/osx/glew/01-fix-makefile.patch

This file was deleted.

26 changes: 0 additions & 26 deletions depends/osx/glew/CMakeLists.txt

This file was deleted.

1 change: 0 additions & 1 deletion depends/osx/glew/glew.txt

This file was deleted.

9 changes: 3 additions & 6 deletions src/main.cpp
Expand Up @@ -26,7 +26,9 @@
#include <assert.h>
#define TO_STRING(...) #__VA_ARGS__
#else
#include <GL/glew.h>
#define GL_GLEXT_PROTOTYPES
#include <GL/gl.h>

This comment has been minimized.

Copy link
@Memphiz

Memphiz Nov 20, 2016

Member

this needs the same handling as spectrum for example:

xbmc/visualization.spectrum@ab83a41

same for the glext.h include in the next line

This comment has been minimized.

Copy link
@akva2

akva2 Nov 21, 2016

Contributor

i guarantee you it's not on purpose ;) fixed in master. please confirm, then i'll bump version.

#include <GL/glext.h>
#endif
#include <iostream>
#include <algorithm>
Expand Down Expand Up @@ -1056,11 +1058,6 @@ ADDON_STATUS ADDON_Create(void* hdl, void* props)

cfg = kiss_fft_alloc(AUDIO_BUFFER, 0, NULL, NULL);

#if !defined(HAS_GLES)
if (GLEW_OK != glewInit()) {
std::cout << "Failed to initialize glew";
}
#endif
if (!initialized)
{
#if defined(HAS_GLES)
Expand Down

1 comment on commit 11371c4

@wsnipex
Copy link
Member

@wsnipex wsnipex commented on 11371c4 Nov 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, confirmed this fixes the intel crash, thanks

Please sign in to comment.