Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1 #1

Merged
merged 6 commits into from Apr 27, 2022
Merged

Feature 1 #1

merged 6 commits into from Apr 27, 2022

Conversation

nottherealalanturing
Copy link
Owner

@nottherealalanturing nottherealalanturing commented Apr 27, 2022

Describe your changes

A minimalist to-do website designed with HTML, CSS, and JS bundled with webpack.
Tasks are currently hardcoded into code with no additional functionality besides being able to view them.

Issue ticket number and link

_

What kind of change does this PR introduce?

New Feature

In which branch do you want the changes to merge?

Main.

Documentation updated ?

Yes.

Checklist

  • No ES Lint Error
  • No Style Lint Error
  • Unit test case update

Screenshots

Screen Shot 2022-04-27 at 08 52 23

Copy link

@Omar-Muhamad Omar-Muhamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ✔

Hi @nottherealalanturing,

Great job, Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Kindly check the optional suggestion.

(Highlights) Good Points: 👍

  • You documented your work professionally. ✔
  • Github flow is used correctly. ✔
  • All linters checks are ok. ✔

(Changes Required) Aspects to improve: ♻️

  • N/A

[Optional] suggestions:

  • [Highly Recommended] Next time kindly add a meaningful branch name that describes what you did in that branch or the name of the feature added to your project for example in this project the name of the branch can be list-structure.

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

**Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@nottherealalanturing nottherealalanturing merged commit a787e72 into main Apr 27, 2022
@nottherealalanturing nottherealalanturing deleted the feature-1 branch May 3, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants